Skip to content

Commit b729c70

Browse files
author
Shahab Moradi
committed
PR comments dotnet#3
1 parent bb2ad55 commit b729c70

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/Microsoft.ML.PCA/PcaTransform.cs

+4-7
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ private sealed class TransformInfo
190190
public float[][] Eigenvectors;
191191
public float[] MeanProjected;
192192

193-
internal ColumnType OutputType => new VectorType(NumberType.Float, Rank);
193+
public ColumnType OutputType => new VectorType(NumberType.Float, Rank);
194194

195195
public TransformInfo(int rank, int dim)
196196
{
@@ -250,7 +250,7 @@ public void Save(ModelSaveContext ctx)
250250
ctx.Writer.WriteFloatArray(MeanProjected);
251251
}
252252

253-
internal void ProjectMean(float[] mean)
253+
public void ProjectMean(float[] mean)
254254
{
255255
Contracts.AssertValue(Eigenvectors);
256256
if (mean == null)
@@ -275,7 +275,7 @@ private static VersionInfo GetVersionInfo()
275275
return new VersionInfo(
276276
modelSignature: "PCA FUNC",
277277
//verWrittenCur: 0x00010001, // Initial
278-
verWrittenCur: 0x00010002, // Get rid of writing float size in model context
278+
verWrittenCur: 0x00010002, // Got rid of writing float size in model context
279279
verReadableCur: 0x00010001,
280280
verWeCanReadBack: 0x00010001,
281281
loaderSignature: LoaderSignature,
@@ -288,10 +288,7 @@ private static VersionInfo GetVersionInfo()
288288

289289
private const string RegistrationName = "Pca";
290290

291-
/// <summary>
292-
/// Public constructor corresponding to SignatureDataTransform.
293-
/// </summary>
294-
public PcaTransform(IHostEnvironment env, IDataView input, ColumnInfo[] columns)
291+
internal PcaTransform(IHostEnvironment env, IDataView input, ColumnInfo[] columns)
295292
: base(Contracts.CheckRef(env, nameof(env)).Register(nameof(PcaTransform)), GetColumnPairs(columns))
296293
{
297294
Host.AssertNonEmpty(ColumnPairs);

0 commit comments

Comments
 (0)