Skip to content

Commit deea06b

Browse files
committed
drm/i915/tgl: apply Display WA raspberrypi#1178 to fix type C dongles
Add port C to workaround to cover Tiger Lake. Cc: Rodrigo Vivi <[email protected]> Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 55cd504 commit deea06b

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

drivers/gpu/drm/i915/display/intel_display_power.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,7 @@ icl_combo_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,
453453
int pw_idx = power_well->desc->hsw.idx;
454454
enum phy phy = ICL_AUX_PW_TO_PHY(pw_idx);
455455
u32 val;
456+
int wa_idx_max;
456457

457458
val = I915_READ(regs->driver);
458459
I915_WRITE(regs->driver, val | HSW_PWR_WELL_CTL_REQ(pw_idx));
@@ -462,9 +463,14 @@ icl_combo_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,
462463

463464
hsw_wait_for_power_well_enable(dev_priv, power_well);
464465

465-
/* Display WA #1178: icl */
466-
if (IS_ICELAKE(dev_priv) &&
467-
pw_idx >= ICL_PW_CTL_IDX_AUX_A && pw_idx <= ICL_PW_CTL_IDX_AUX_B &&
466+
/* Display WA #1178: icl, tgl */
467+
if (IS_TIGERLAKE(dev_priv))
468+
wa_idx_max = ICL_PW_CTL_IDX_AUX_C;
469+
else
470+
wa_idx_max = ICL_PW_CTL_IDX_AUX_B;
471+
472+
if (!IS_ELKHARTLAKE(dev_priv) &&
473+
pw_idx >= ICL_PW_CTL_IDX_AUX_A && pw_idx <= wa_idx_max &&
468474
!intel_bios_is_port_edp(dev_priv, (enum port)phy)) {
469475
val = I915_READ(ICL_AUX_ANAOVRD1(pw_idx));
470476
val |= ICL_AUX_ANAOVRD1_ENABLE | ICL_AUX_ANAOVRD1_LDO_BYPASS;

drivers/gpu/drm/i915/i915_reg.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9244,9 +9244,11 @@ enum skl_power_gate {
92449244
#define _ICL_AUX_REG_IDX(pw_idx) ((pw_idx) - ICL_PW_CTL_IDX_AUX_A)
92459245
#define _ICL_AUX_ANAOVRD1_A 0x162398
92469246
#define _ICL_AUX_ANAOVRD1_B 0x6C398
9247+
#define _TGL_AUX_ANAOVRD1_C 0x160398
92479248
#define ICL_AUX_ANAOVRD1(pw_idx) _MMIO(_PICK(_ICL_AUX_REG_IDX(pw_idx), \
92489249
_ICL_AUX_ANAOVRD1_A, \
9249-
_ICL_AUX_ANAOVRD1_B))
9250+
_ICL_AUX_ANAOVRD1_B, \
9251+
_TGL_AUX_ANAOVRD1_C))
92509252
#define ICL_AUX_ANAOVRD1_LDO_BYPASS (1 << 7)
92519253
#define ICL_AUX_ANAOVRD1_ENABLE (1 << 0)
92529254

0 commit comments

Comments
 (0)