Skip to content

Post-mortem for regression in 3.5.0 #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
woodruffw opened this issue Oct 25, 2024 · 1 comment · Fixed by #1198
Closed

Post-mortem for regression in 3.5.0 #1194

woodruffw opened this issue Oct 25, 2024 · 1 comment · Fixed by #1198
Labels
bug Something isn't working component:cli CLI components

Comments

@woodruffw
Copy link
Member

Release 3.5.0 had a minor regression which we only noticed after release: handling of "legacy" sigstore bundles (i.e. .sigstore instead of .sigstore.json) was broken by an overly broad check on .crt/.sig inputs.

No other verification flows were affected, including any flows where a user passes the verification materials explicitly rather than discovering them via file suffixes.

Resolution

We released 3.5.1 with a fix.

Improvement items

We should have an integration test that ensures we don't regress on this CLI behavior again.

@woodruffw
Copy link
Member Author

CC @facutuesca could you try and extend our current integration tests to cover this? Should be as simple as ensuring that sigstore verify ... foo.txt continues to work when foo.txt.sigstore (and only .sigstore, not .sigstore.json) is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:cli CLI components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant