Skip to content

Parsing KindVersion in rekor V2 #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonpetgrave64 opened this issue May 7, 2025 · 2 comments · Fixed by #1370
Closed

Parsing KindVersion in rekor V2 #1369

ramonpetgrave64 opened this issue May 7, 2025 · 2 comments · Fixed by #1370
Labels
enhancement New feature or request

Comments

@ramonpetgrave64
Copy link
Contributor

Client support for Rekor V2: sigstore-python

Description

In rekor V2, me may not be including the KindVersion in the "canonicalized body", while still having the KindVersion in the root of the response, just as in rekor V1.

This issue tracks a fix to make the parsing the KindVersion forward compatible.

For rekor V1, I think we will likely continue to use LogEntry._from_response(), while for rekor V2, we would use start using LogEntry_from_dict_rekor(), which works so far in my testing for parsing responses. (more are changes required for sending requests and verifying signatures.)

@jku
Copy link
Member

jku commented May 16, 2025

Let's not close this once #1370 merges (a new issue is fine too): let's also make sure the failure on unsupported kindVersions is reasonable -- this is important in the verify case

@jku
Copy link
Member

jku commented May 19, 2025

Let's not close this once #1370 merges (a new issue is fine too)

I filed #1394 as a separate issue

@jku jku closed this as completed in #1370 May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants