Skip to content

CI: staging fixture not working #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonpetgrave64 opened this issue May 22, 2025 · 0 comments · Fixed by #1409
Closed

CI: staging fixture not working #1408

ramonpetgrave64 opened this issue May 22, 2025 · 0 comments · Fixed by #1409
Labels
bug Something isn't working

Comments

@ramonpetgrave64
Copy link
Contributor

ramonpetgrave64 commented May 22, 2025

Client support for Rekor V2: sigstore-python

Description

The staging fixture needs updating, after merging #1363. It's strange that the tests didn't fail within the PR's checks, only after merging. Tests also fail locally.

https://github.com/sigstore/sigstore-python/actions/runs/15190933113/job/42723267534#step:6:217

==================================== ERRORS ====================================
_________ ERROR at setup of test_sign_rekor_entry_consistent[staging] __________

pytestconfig = <_pytest.config.Config object at 0x7f69195a64d0>, env = 'staging'

    @pytest.fixture
    def sign_ctx_and_ident_for_env(
        pytestconfig,
        env: str,
    ) -> tuple[type[SigningContext], type[IdentityToken]]:
        if env == "staging":
>           ctx_cls = SigningContext.staging
E           AttributeError: type object 'SigningContext' has no attribute 'staging'

env        = 'staging'
pytestconfig = <_pytest.config.Config object at 0x7f69195a64d0>

test/unit/conftest.py:192: AttributeError

Version

@main 916c2c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant