Skip to content

Commit cc41a7e

Browse files
Merge pull request openshift#18394 from mfojtik/disable-router-test
Automatic merge from submit-queue (batch tested with PRs 18394, 18542). router: add permissions for dumping router pods in tests Alternative to openshift#18382 ? @deads2k it is still weird that the SA here gets the access to endpoints and routes (cluster-wide) but not the services (hence the permission error). My previous fix was wrong, because I was waiting for the user to get the cluster perms, but seems like the SA need that perm as well. I guess when the user create router, the SA in Pod that run the router will inherit that permissions, but it seems like it only gets routes and endpoints?
2 parents cd43d79 + b933a00 commit cc41a7e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/extended/router/metrics.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ var _ = g.Describe("[Conformance][Area:Networking][Feature:Router] openshift rou
7575

7676
g.AfterEach(func() {
7777
if g.CurrentGinkgoTestDescription().Failed {
78-
exutil.DumpPodLogsStartingWithInNamespace("router", "default", oc)
78+
exutil.DumpPodLogsStartingWithInNamespace("router", "default", oc.AsAdmin())
7979
}
8080
})
8181

0 commit comments

Comments
 (0)