Skip to content

Commit 24696fc

Browse files
committed
[base-ui] Fix tooltip update issue
Summary: 使用 dom dataset 来缓存 以及 vuejs/vue#314 Test Plan: as above Reviewers: #web_reviewers, kuilin Reviewed By: #web_reviewers, kuilin Differential Revision: https://code.yangqianguan.com/D45553
1 parent 3001185 commit 24696fc

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

dist/base-ui.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "base-ui",
3-
"version": "0.0.111",
3+
"version": "0.0.112",
44
"description": "A component library for Better Vue developmemt",
55
"main": "./dist/base-ui.min.js",
66
"repository": {

src/directive/tooltip/tooltip.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ export default {
3232
},
3333

3434
inserted(el, {value}, vnode) {
35-
vnode.$$curTipText = value;
35+
el.dataset.tipText = value;
3636

3737
vnode.$$tooltipMouseover = () => {
38-
toolTipEle.innerText = vnode.$$curTipText;
38+
toolTipEle.innerText = el.dataset.tipText;
3939
Object.assign(toolTipEle.style, {
4040
display: 'block'
4141
});
@@ -57,8 +57,8 @@ export default {
5757
el.addEventListener('mouseout', vnode.$$tooltipMouseout);
5858
},
5959

60-
update(el, {value}, vnode) {
61-
vnode.$$curTipText = value;
60+
update(el, {value}) {
61+
el.dataset.tipText = value;
6262
},
6363

6464
unbind(el, binding, vnode) {

0 commit comments

Comments
 (0)