Support RegExp v flag (#2195)

Author: fisker

Diff for: rules/better-regex.js

@@ -28,10 +28,9 @@ const create = context => {
 			}
 
 			const {raw: original, regex} = node;
-
-			// Regular Expressions with `u` flag are not well handled by `regexp-tree`
+			// Regular Expressions with `u` and `v` flag are not well handled by `regexp-tree`
 			// https://github.com/DmitrySoshnikov/regexp-tree/issues/162
-			if (regex.flags.includes('u')) {
+			if (regex.flags.includes('u') || regex.flags.includes('v')) {
 				return;
 			}
 

Diff for: rules/prefer-regexp-test.js

@@ -77,6 +77,10 @@ const cases = [
 const isRegExpNode = node => isRegexLiteral(node) || isNewExpression(node, {name: 'RegExp'});
 
 const isRegExpWithoutGlobalFlag = (node, scope) => {
+	if (isRegexLiteral(node)) {
+		return !node.regex.flags.includes('g');
+	}
+
 	const staticResult = getStaticValue(node, scope);
 
 	// Don't know if there is `g` flag

Diff for: rules/prefer-string-replace-all.js

@@ -17,15 +17,16 @@ function getPatternReplacement(node) {
 	}
 
 	const {pattern, flags} = node.regex;
-	if (flags.replace('u', '') !== 'g') {
+	if (flags.replace('u', '').replace('v', '') !== 'g') {
 		return;
 	}
 
 	let tree;
 
 	try {
 		tree = parseRegExp(pattern, flags, {
-			unicodePropertyEscape: true,
+			unicodePropertyEscape: flags.includes('u'),
+			unicodeSet: flags.includes('v'),
 			namedGroups: true,
 			lookbehind: true,
 		});

Diff for: test/better-regex.mjs

@@ -40,6 +40,7 @@ test({
 		// Should not crash ESLint (#446 and #448)
 		'/\\{\\{verificationUrl\\}\\}/gu',
 		'/^test-(?<name>[a-zA-Z-\\d]+)$/u',
+		String.raw`/[\p{Script_Extensions=Greek}--π]/v`,
 
 		// Should not suggest wrong regex (#447)
 		'/(\\s|\\.|@|_|-)/u',

Diff for: test/prefer-regexp-test.mjs

@@ -150,6 +150,8 @@ test.snapshot({
 			let re = new RegExp('foo', 'g');
 			if(str.match(re));
 		`,
+		'!/a/u.exec(foo)',
+		'!/a/v.exec(foo)',
 	],
 });
 
@@ -173,3 +175,40 @@ test.vue({
 		},
 	],
 });
+
+const supportsUnicodeSets = (() => {
+	try {
+		// eslint-disable-next-line prefer-regex-literals -- Can't test with regex literal
+		return new RegExp('.', 'v').unicodeSets;
+	} catch {}
+
+	return false;
+})();
+// These cases can be auto-fixed in environments supports `v` flag (eg, Node.js v20),
+// But will use suggestions instead in environments doesn't support `v` flag.
+test({
+	valid: [],
+	invalid: [
+		{
+			code: 'const re = /a/v; !re.exec(foo)',
+			output: 'const re = /a/v; !re.test(foo)',
+		},
+		{
+			code: 'const re = new RegExp("a", "v"); !re.exec(foo)',
+			output: 'const re = new RegExp("a", "v"); !re.test(foo)',
+		},
+	].map(({code, output}) =>
+		supportsUnicodeSets
+			? {
+				code,
+				output,
+				errors: 1,
+			}
+			: {
+				code,
+				errors: [
+					{suggestions: [{output}]},
+				],
+			},
+	),
+});

Diff for: test/prefer-string-replace-all.mjs

@@ -77,11 +77,13 @@ test.snapshot({
 		'foo.replace(/\\W/g, bar)',
 		'foo.replace(/\\u{61}/g, bar)',
 		'foo.replace(/\\u{61}/gu, bar)',
+		'foo.replace(/\\u{61}/gv, bar)',
 		'foo.replace(/]/g, "bar")',
 		// Extra flag
 		'foo.replace(/a/gi, bar)',
 		'foo.replace(/a/gui, bar)',
 		'foo.replace(/a/uig, bar)',
+		'foo.replace(/a/vig, bar)',
 		// Variables
 		'const pattern = new RegExp("foo", "g"); foo.replace(pattern, bar)',
 		'foo.replace(new RegExp("foo", "g"), bar)',
@@ -99,9 +101,11 @@ test.snapshot({
 		'foo.replace(/\\u{1f600}/gu, _)',
 		'foo.replace(/\\n/g, _)',
 		'foo.replace(/\\u{20}/gu, _)',
+		'foo.replace(/\\u{20}/gv, _)',
 
 		'foo.replaceAll(/a]/g, _)',
 		'foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)',
+		'foo.replaceAll(/\\r\\n\\u{1f600}/gv, _)',
 		`foo.replaceAll(/a${' very'.repeat(30)} long string/g, _)`,
 
 		// Invalid RegExp #2010

Diff for: test/prefer-string-starts-ends-with.mjs

@@ -219,6 +219,8 @@ test.snapshot({
 		'/a$/.test(a ??= b)',
 		'/^a/.test(a || b)',
 		'/^a/.test(a && b)',
+		'/^a/u.test("string")',
+		'/^a/v.test("string")',
 		// eslint-disable-next-line no-template-curly-in-string
 		'/a$/.test(`${unknown}`)',
 		'/a$/.test(String(unknown))',

Diff for: test/snapshots/prefer-regexp-test.mjs.md

@@ -927,3 +927,35 @@ Generated by [AVA](https://avajs.dev).
       1 | let re = new RegExp('foo', 'g');␊
       2 | if(re.test(str));␊
     `
+
+## Invalid #57
+      1 | !/a/u.exec(foo)
+
+> Output
+
+    `␊
+      1 | !/a/u.test(foo)␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | !/a/u.exec(foo)␊
+        |       ^^^^ Prefer \`.test(…)\` over \`.exec(…)\`.␊
+    `
+
+## Invalid #58
+      1 | !/a/v.exec(foo)
+
+> Output
+
+    `␊
+      1 | !/a/v.test(foo)␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | !/a/v.exec(foo)␊
+        |       ^^^^ Prefer \`.test(…)\` over \`.exec(…)\`.␊
+    `