[REFACTOR] [Hacker Rank] Warmup: Time Conversion solved ✅. Simplified.

+ safer version
+ coverage increased.

Author: Gonzalo Diaz

src/lib/exercises/include/exercises/hackerrank/warmup/time_conversion.h

@@ -3,8 +3,9 @@
 #ifdef __cplusplus
 extern "C" {
 #endif
-char *HACKERRANK_WARMUP_firstN(const char *s, unsigned long n);
-char *HACKERRANK_WARMUP_lastN(const char *s, unsigned long n);
+
+char *HACKERRANK_WARMUP_getStringFragment(const char *s, unsigned long len,
+                                          unsigned long from, unsigned long to);
 
 char *HACKERRANK_WARMUP_timeConversion(const char *s);
 

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

@@ -4,80 +4,42 @@
  * @link Problem definition [[docs/hackerrank/warmup/time_conversion.md]]
  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
+#include <stdio.h>  // snprintf
+#include <stdlib.h> // malloc, free, strtol
+#include <string.h> // strcmp, strnlen
 
-char *HACKERRANK_WARMUP_firstN(const char *s, unsigned long n) {
-  unsigned long len = strlen(s);
-  if (n > len) {
-    return NULL;
-  }
-  if (n == 0) {
-    return NULL;
-  }
+#define HACKERRANK_WARMUP_LONG_TIME_FORMAT_SIZE 10
+#define HACKERRANK_WARMUP_SHORT_TIME_FORMAT_SIZE 8
+#define HACKERRANK_WARMUP_HOUR_FORMAT_SIZE 2
 
-  char *result = (char *)malloc((n + 1) * sizeof(char));
-  if (result == NULL) {
+char *HACKERRANK_WARMUP_timeConversion(const char *s) {
+  if (s == NULL) {
     return NULL;
   }
 
-  strncpy(result, s, n);
-
-  result[n] = '\0';
+  size_t s_len = strnlen(s, HACKERRANK_WARMUP_LONG_TIME_FORMAT_SIZE);
 
-  return result;
-}
-
-char *HACKERRANK_WARMUP_lastN(const char *s, unsigned long n) {
-  unsigned long len = strlen(s);
-  if (n > len) {
-    return NULL;
-  }
-  if (n == 0) {
+  if (s_len != HACKERRANK_WARMUP_LONG_TIME_FORMAT_SIZE) {
     return NULL;
   }
 
-  char *result = (char *)malloc((n + 1) * sizeof(char));
-  if (result == NULL) {
-    return NULL;
-  }
-
-  strncpy(result, s + len - n, n);
-
-  result[n] = '\0';
-
-  return result;
-}
+  char hour_str[HACKERRANK_WARMUP_HOUR_FORMAT_SIZE + 1];
 
-char *HACKERRANK_WARMUP_timeConversion(const char *s) {
-  char *meridian = HACKERRANK_WARMUP_lastN(s, 2);
+  hour_str[0] = s[0];
+  hour_str[1] = s[1];
+  hour_str[2] = '\0';
 
-  char *hour_str = HACKERRANK_WARMUP_firstN(s, 2);
-  char *time_str = (char *)malloc((strlen(s) + 1) * sizeof(char));
-  if (time_str == NULL) {
-    free(hour_str);
-    free(meridian);
-    return NULL;
-  }
-  strcpy(time_str, s);
-  char *temp_time_str = HACKERRANK_WARMUP_lastN(time_str, strlen(time_str) - 2);
-  free(time_str);
-  time_str = temp_time_str;
-  temp_time_str = HACKERRANK_WARMUP_firstN(time_str, strlen(time_str) - 2);
-  free(time_str);
-  time_str = temp_time_str;
+  char meridian[3];
+  meridian[0] = s[s_len - 2];
+  meridian[1] = s[s_len - 1];
+  meridian[2] = '\0';
 
   char *endptr;
   long hour = strtol(hour_str, &endptr, 10);
 
   if (*endptr != '\0') {
     printf("Conversion error, non-convertible part: %s\n", endptr);
 
-    free(hour_str);
-    free(meridian);
-    free(time_str);
-    free(endptr);
     return NULL;
   } else {
     printf("The integer value is: %ld\n", hour);
@@ -89,14 +51,18 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
     hour += 12;
   }
 
-  const int BUFFER_MAX_SIZE = 9;
+  char *conversion =
+      malloc((HACKERRANK_WARMUP_SHORT_TIME_FORMAT_SIZE + 1) * sizeof(char));
+
+  for (int i = 0; i < HACKERRANK_WARMUP_SHORT_TIME_FORMAT_SIZE; i++) {
+    conversion[i] = s[i];
+  }
+  conversion[HACKERRANK_WARMUP_SHORT_TIME_FORMAT_SIZE] = '\0';
 
-  char *conversion = malloc(BUFFER_MAX_SIZE * sizeof(char));
+  snprintf(hour_str, HACKERRANK_WARMUP_HOUR_FORMAT_SIZE + 1, "%02ld", hour);
 
-  snprintf(conversion, BUFFER_MAX_SIZE, "%02ld%s", hour, time_str);
-  free(hour_str);
-  free(meridian);
-  free(time_str);
+  conversion[0] = hour_str[0];
+  conversion[1] = hour_str[1];
 
   return conversion;
 }

src/tests/unit/lib/hackerrank/warmup/time_conversion.test.cpp

@@ -32,11 +32,10 @@ TEST_CASE("time_conversion JSON Test Cases",
   }
 }
 
-TEST_CASE("time_conversion helper functions edge cases",
-          "[hackerrank] [helper] [warmup]") {
-  CHECK(HACKERRANK_WARMUP_firstN("", 10) == nullptr);
-  CHECK(HACKERRANK_WARMUP_lastN("", 10) == nullptr);
+TEST_CASE("time_conversion edge cases", "[hackerrank] [helper] [warmup]") {
+  CHECK(HACKERRANK_WARMUP_timeConversion(nullptr) == nullptr);
 
-  CHECK(HACKERRANK_WARMUP_firstN("", 0) == nullptr);
-  CHECK(HACKERRANK_WARMUP_lastN("", 0) == nullptr);
+  CHECK(HACKERRANK_WARMUP_timeConversion("") == nullptr);
+
+  CHECK(HACKERRANK_WARMUP_timeConversion("aa:bb:ccXM") == nullptr);
 }