[BUGFIX] sonarcloud: Remove this method and declare a constant for this value.

Gonzalo Diaz · Gonzalo Diaz · commit 2496b739f63c · 2024-05-13T13:21:49.000-04:00
Methods should not return constants csharpsquid:S3400
diff --git a/algorithm-exercises-csharp/Hello.cs b/algorithm-exercises-csharp/Hello.cs
@@ -4,12 +4,14 @@ namespace algorithm_exercises_csharp;
 
 public class HelloWorld
 {
+  const string message = "Hello World!";
+
   [ExcludeFromCodeCoverage]
   protected HelloWorld() {}
 
   public static string Hello()
   {
-    return "Hello World!";
+    return HelloWorld.message;
   }
 
   public static HelloWorld Create() {

Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,14 @@ namespace algorithm_exercises_csharp;`
`4`	`4`
`5`	`5`	`public class HelloWorld`
`6`	`6`	`{`
	`7`	`+ const string message = "Hello World!";`
	`8`	`+`
`7`	`9`	`[ExcludeFromCodeCoverage]`
`8`	`10`	`protected HelloWorld() {}`
`9`	`11`
`10`	`12`	`public static string Hello()`
`11`	`13`	`{`
`12`		`- return "Hello World!";`
	`14`	`+ return HelloWorld.message;`
`13`	`15`	`}`
`14`	`16`
`15`	`17`	`public static HelloWorld Create() {`