[REFACTOR] [Hacker Rank] Interview Preparation Kit: Arrays: New Year Chaos. Adjusted the interface to match what hackerrank expects.

Author: sir-gon

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from '@jest/globals';
 import { logger as console } from '../../../logger';
 
-import { minimumBribesTransform } from './new_year_chaos';
+import nyc from './new_year_chaos';
 
 import TEST_CASES from './new_year_chaos.testcases.json';
 
@@ -10,7 +10,8 @@ describe('new_year_chaos', () => {
     expect.assertions(5);
 
     TEST_CASES.forEach((value) => {
-      const answer = minimumBribesTransform(value.input);
+      const answer = nyc.minimumBribesText(value.input);
+      nyc.minimumBribes(value.input);
 
       console.debug(
         `minimumBribesTransform(${value.input.toString()}) solution found: ${answer}`

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.testcases.json

@@ -1,27 +1,27 @@
 [
-    {
-      "title": "Test Case 0-0",
-      "input": [2, 1, 5, 3, 4],
-      "expected": 3
-    },
-    {
-     "title": "Test Case 0-1",
-     "input": [2, 5, 1, 3, 4],
-     "expected": "Too chaotic"
-    },
-    {
-     "title": "Test Case 1-1",
-     "input": [5, 1, 2, 3, 7, 8, 6, 4],
-     "expected": "Too chaotic"
-    },
-    {
-      "title": "Test Case 1-2",
-      "input": [1, 2, 5, 3, 7, 8, 6, 4],
-      "expected": 7
-    },
-    {
-      "title": "Test Case 2",
-      "input": [1, 2, 5, 3, 4, 7, 8, 6],
-      "expected": 4
-    }
-  ]
+  {
+    "title": "Test Case 0-0",
+    "input": [2, 1, 5, 3, 4],
+    "expected": "3"
+  },
+  {
+    "title": "Test Case 0-1",
+    "input": [2, 5, 1, 3, 4],
+    "expected": "Too chaotic"
+  },
+  {
+    "title": "Test Case 1-1",
+    "input": [5, 1, 2, 3, 7, 8, 6, 4],
+    "expected": "Too chaotic"
+  },
+  {
+    "title": "Test Case 1-2",
+    "input": [1, 2, 5, 3, 7, 8, 6, 4],
+    "expected": "7"
+  },
+  {
+    "title": "Test Case 2",
+    "input": [1, 2, 5, 3, 4, 7, 8, 6],
+    "expected": "4"
+  }
+]

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.ts

@@ -2,10 +2,10 @@
  * @link Problem definition [[docs/hackerrank/interview_preparation_kit/arrays/new_year_chaos.md]]
  */
 
-export const TOO_CHAOTIC_ERROR = 'Too chaotic';
-export const NEW_YEAR_CHAOS_TOLERANCE = 2;
+const TOO_CHAOTIC_ERROR = 'Too chaotic';
+const NEW_YEAR_CHAOS_TOLERANCE = 2;
 
-export function minimumBribes(q: number[]): number {
+function minimumBribesCalculate(q: number[]): number {
   let bribes = 0;
   let i = 0;
 
@@ -15,7 +15,10 @@ export function minimumBribes(q: number[]): number {
       throw new Error(TOO_CHAOTIC_ERROR);
     }
 
-    const fragment = q.slice(Math.max(value - NEW_YEAR_CHAOS_TOLERANCE, 0), i);
+    const fragment = q.slice(
+      Math.min(Math.max(value - NEW_YEAR_CHAOS_TOLERANCE, 0), i),
+      i
+    );
 
     fragment.forEach((k) => {
       if (k > value) {
@@ -28,11 +31,11 @@ export function minimumBribes(q: number[]): number {
   return bribes;
 }
 
-export function minimumBribesTransform(queue: number[]): number | string {
-  let result: number | string = '';
+function minimumBribesText(queue: number[]): string {
+  let result = '';
 
   try {
-    result = minimumBribes(queue);
+    result = `${minimumBribesCalculate(queue)}`;
   } catch (err: unknown) {
     if (err instanceof Error) {
       result = err.message;
@@ -42,4 +45,8 @@ export function minimumBribesTransform(queue: number[]): number | string {
   return result;
 }
 
-export default { minimumBribes, minimumBribesTransform, TOO_CHAOTIC_ERROR };
+function minimumBribes(q: number[]): void {
+  console.log(minimumBribesText(q));
+}
+
+export default { minimumBribes, minimumBribesText, TOO_CHAOTIC_ERROR };