Avoid showing the quiz pop-up twice to the user

Due to the current flow of code it's possible that in
some cases the quiz pop-up is shown to the user twice.
This is unnecessary and unintentional.

So, change the logic in such a way that the quiz pop-up
would be never be shown twice to the user.

Fixes: commons-app#3281

Author: kaartic-sn-20010

app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.java

@@ -59,8 +59,7 @@ public QuizChecker(SessionManager sessionManager,
     }
 
     public void initQuizCheck(Activity activity) {
-        setUploadCount(activity);
-        setRevertCount(activity);
+        calculateRevertParameterAndShowQuiz(activity);
     }
 
     public void cleanup() {
@@ -92,7 +91,6 @@ private void setTotalUploadCount(Activity activity, int uploadCount) {
             revertKvStore.putInt(UPLOAD_SHARED_PREFERENCE, 0);
         }
         isUploadCountFetched = true;
-        calculateRevertParameter(activity);
     }
 
     /**
@@ -123,13 +121,14 @@ private void setRevertParameter(Activity activity, int revertCountFetched) {
             revertKvStore.putInt(REVERT_SHARED_PREFERENCE, 0);
         }
         isRevertCountFetched = true;
-        calculateRevertParameter(activity);
     }
 
     /**
      * to check whether the criterion to call quiz is satisfied
      */
-    private void calculateRevertParameter(Activity activity) {
+    private void calculateRevertParameterAndShowQuiz(Activity activity) {
+        setUploadCount(activity);
+        setRevertCount(activity);
         if ( revertCount < 0 || totalUploadCount < 0){
             revertKvStore.putInt(REVERT_SHARED_PREFERENCE, 0);
             revertKvStore.putInt(UPLOAD_SHARED_PREFERENCE, 0);