Skip to content

Commit 1496de2

Browse files
bpasteneCommit Bot
authored and
Commit Bot
committed
Remove implied CIPD packages from scripts/trigger.py
All of chromium's test pools should have these packages automatically added via task templates. So there's no need to add them ourselves in this script. Bug: chromium:812428 Change-Id: I283ad5963cdf237220545c5ed1f21892f6ade18e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2241901 Commit-Queue: Yuly Novikov <[email protected]> Reviewed-by: Yuly Novikov <[email protected]> Reviewed-by: Robbie Iannucci <[email protected]>
1 parent 62a2f51 commit 1496de2

File tree

1 file changed

+0
-43
lines changed

1 file changed

+0
-43
lines changed

scripts/trigger.py

-43
Original file line numberDiff line numberDiff line change
@@ -25,47 +25,6 @@ def parse_args():
2525
return parser.parse_known_args()
2626

2727

28-
# Taken from:
29-
# https://chromium.googlesource.com/chromium/src/tools/mb/+/2192df66cd0ed214bcfbfd387ad0c5c8c0a21eb1/mb.py#586
30-
def add_base_software(swarming_args):
31-
# HACK(iannucci): These packages SHOULD NOT BE HERE.
32-
# Remove method once Swarming Pool Task Templates are implemented.
33-
# crbug.com/812428
34-
35-
# Add in required base software. This should be kept in sync with the
36-
# `chromium_swarming` recipe module in build.git. All references to
37-
# `swarming_module` below are purely due to this.
38-
cipd_packages = [
39-
('infra/python/cpython/${platform}', 'version:2.7.15.chromium14'),
40-
('infra/tools/luci/logdog/butler/${platform}',
41-
'git_revision:e1abc57be62d198b5c2f487bfb2fa2d2eb0e867c'),
42-
('infra/tools/luci/vpython-native/${platform}',
43-
'git_revision:e317c7d2c17d4c3460ee37524dfce4e1dee4306a'),
44-
('infra/tools/luci/vpython/${platform}',
45-
'git_revision:e317c7d2c17d4c3460ee37524dfce4e1dee4306a'),
46-
]
47-
48-
for pkg, vers in cipd_packages:
49-
swarming_args.append('--cipd-package=.swarming_module:%s=%s' % (pkg, vers))
50-
51-
# Add packages to $PATH
52-
swarming_args.extend([
53-
'--env-prefix',
54-
'PATH=.swarming_module',
55-
'--env-prefix',
56-
'PATH=.swarming_module/bin',
57-
])
58-
59-
# Add cache directives for vpython.
60-
vpython_cache_path = '.swarming_module_cache/vpython'
61-
swarming_args.extend([
62-
'--named-cache',
63-
'swarming_module_cache_vpython=' + vpython_cache_path,
64-
'--env-prefix',
65-
'VPYTHON_VIRTUALENV_ROOT=' + vpython_cache_path,
66-
])
67-
68-
6928
def main():
7029
args, unknown = parse_args()
7130
path = args.gn_path.replace('\\', '/')
@@ -96,8 +55,6 @@ def main():
9655
'-d', 'gpu=' + args.gpu_dim, '-s', sha
9756
]
9857

99-
add_base_software(swarming_args)
100-
10158
for i in range(args.shards):
10259
shard_args = swarming_args[:]
10360
shard_args.extend([

0 commit comments

Comments
 (0)