Add fix for NON_FINAL_FIELD_IN_ENUM

Change-Id: I4eb8125468290af44b65343d620ee2646c2594c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270800
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -791,8 +791,8 @@ CompileTimeErrorCode.NON_CONSTANT_MAP_VALUE_FROM_DEFERRED_LIBRARY:
 CompileTimeErrorCode.NON_CONSTANT_SET_ELEMENT:
   status: needsEvaluation
 CompileTimeErrorCode.NON_FINAL_FIELD_IN_ENUM:
-  status: needsFix
-  notes: Use MakeFinal.new
+  status: hasFix
+  since: 2.17
 CompileTimeErrorCode.NON_GENERATIVE_CONSTRUCTOR:
   status: needsEvaluation
 CompileTimeErrorCode.NON_GENERATIVE_IMPLICIT_CONSTRUCTOR:

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -1082,6 +1082,9 @@ class FixProcessor extends BaseProcessor {
     CompileTimeErrorCode.NON_CONST_GENERATIVE_ENUM_CONSTRUCTOR: [
       AddConst.new,
     ],
+    CompileTimeErrorCode.NON_FINAL_FIELD_IN_ENUM: [
+      MakeFinal.new,
+    ],
     CompileTimeErrorCode.NON_TYPE_AS_TYPE_ARGUMENT: [
       CreateClass.new,
       CreateMixin.new,

pkg/analysis_server/test/src/services/correction/fix/make_final_test.dart

@@ -11,6 +11,7 @@ import 'fix_processor.dart';
 
 void main() {
   defineReflectiveSuite(() {
+    defineReflectiveTests(NonFinalFieldInEnumTest);
     defineReflectiveTests(PreferFinalFieldsBulkTest);
     defineReflectiveTests(PreferFinalFieldsTest);
     defineReflectiveTests(PreferFinalFieldsWithNullSafetyTest);
@@ -21,6 +22,42 @@ void main() {
   });
 }
 
+@reflectiveTest
+class NonFinalFieldInEnumTest extends FixProcessorTest {
+  @override
+  FixKind get kind => DartFixKind.MAKE_FINAL;
+
+  Future<void> test_field_type() async {
+    await resolveTestCode('''
+enum E {
+  one, two;
+  int f = 2;
+}
+''');
+    await assertHasFix('''
+enum E {
+  one, two;
+  final int f = 2;
+}
+''');
+  }
+
+  Future<void> test_field_var() async {
+    await resolveTestCode('''
+enum E {
+  one, two;
+  var f = 2;
+}
+''');
+    await assertHasFix('''
+enum E {
+  one, two;
+  final f = 2;
+}
+''');
+  }
+}
+
 @reflectiveTest
 class PreferFinalFieldsBulkTest extends BulkFixProcessorTest {
   @override