-
Notifications
You must be signed in to change notification settings - Fork 846
Add SignatureVerifier for request verification #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 84.76% 85.29% +0.53%
==========================================
Files 17 19 +2
Lines 2474 2604 +130
Branches 236 244 +8
==========================================
+ Hits 2097 2221 +124
- Misses 283 287 +4
- Partials 94 96 +2
Continue to review full report at Codecov.
|
0143c25
to
2380e6f
Compare
2835d89
to
c352e88
Compare
seratch
added a commit
to seratch/python-slack-sdk
that referenced
this pull request
May 15, 2020
seratch
added a commit
to seratch/python-slack-sdk
that referenced
this pull request
May 15, 2020
seratch
added a commit
to seratch/python-slack-sdk
that referenced
this pull request
May 15, 2020
2 tasks
seratch
added a commit
that referenced
this pull request
May 15, 2020
Additional improvements for #686 and document updates
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the official implementation of Slack request verification. We have been having this logic as a static method in
BaseClient
but it's not the right place to have it.When we release version 2.6.0 with this change, I'll update this part of the document. https://slack.dev/python-slackclient/basic_usage.html#opening-a-modal
Requirements (place an
x
in each[ ]
)