Skip to content

Commit dd81d9e

Browse files
authored
Merge pull request #172 from asalvi0/improve-updater
Improve updater and Go -> 1.20
2 parents a85ceeb + 30107c6 commit dd81d9e

File tree

4 files changed

+21
-28
lines changed

4 files changed

+21
-28
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
15-
go: ['1.22', '1.21', '1.20', '1.19']
15+
go: ['1.23', '1.22', '1.21', '1.20']
1616
name: Test on ${{ matrix.go }}
1717
steps:
1818
- uses: actions/checkout@v4

_automation/main.go

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ func root(args []string) error {
8181
flagsParse(fs, args[1:])
8282

8383
s.CheckUpdates(ctx)
84+
8485
case "update":
8586
if len(args) < 2 {
8687
return fmt.Errorf("language argument is missing")
@@ -91,11 +92,15 @@ func root(args []string) error {
9192
flagsParse(fs, args[2:])
9293

9394
s.Update(ctx, args[1], *force)
95+
s.writeGrammarsFile(ctx)
96+
9497
case "update-all":
9598
fs := flag.NewFlagSet("update-all", flag.ExitOnError)
9699
flagsParse(fs, args[1:])
97100

98-
s.UpdateAll(ctx)
101+
s.UpdateAll(ctx, true)
102+
s.writeGrammarsFile(ctx)
103+
99104
default:
100105
return fmt.Errorf("unknown sub-command")
101106
}
@@ -194,33 +199,20 @@ func (s *UpdateService) Update(ctx context.Context, language string, force bool)
194199
}
195200

196201
s.downloadGrammar(ctx, grammar)
197-
s.writeGrammarsFile(ctx)
198202
}
199203

200-
func (s *UpdateService) UpdateAll(ctx context.Context) {
201-
newVersions := s.fetchNewVersions()
202-
204+
func (s *UpdateService) UpdateAll(ctx context.Context, force bool) {
203205
wg := sync.WaitGroup{}
204-
for i, g := range s.grammars {
205-
v := newVersions[i]
206-
if v == nil {
207-
continue
208-
}
209-
206+
for _, g := range s.grammars {
210207
wg.Add(1)
211-
g.Reference = v.Reference
212-
g.Revision = v.Revision
213208

214209
go func(g *Grammar) {
215210
defer wg.Done()
216211

217-
s.downloadGrammar(ctx, g)
212+
s.Update(ctx, g.Language, force)
218213
}(g)
219214
}
220-
221215
wg.Wait()
222-
223-
s.writeGrammarsFile(ctx)
224216
}
225217

226218
func (s *UpdateService) downloadGrammar(ctx context.Context, g *Grammar) {
@@ -310,7 +302,7 @@ func (s *UpdateService) fetchFile(ctx context.Context, url string) []byte {
310302
defer resp.Body.Close()
311303

312304
if resp.StatusCode != 200 {
313-
logAndExit(logger, "incorrect response status code", "statusCode", resp.StatusCode)
305+
logger.Error("incorrect response status code", "statusCode", resp.StatusCode)
314306
}
315307

316308
b, err := io.ReadAll(resp.Body)

go.mod

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
module github.com/smacker/go-tree-sitter
22

3-
go 1.13
3+
go 1.20
44

5-
require github.com/stretchr/testify v1.7.4
5+
require github.com/stretchr/testify v1.9.0
6+
7+
require (
8+
github.com/davecgh/go-spew v1.1.1 // indirect
9+
github.com/pmezard/go-difflib v1.0.0 // indirect
10+
gopkg.in/yaml.v3 v3.0.1 // indirect
11+
)

go.sum

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
1-
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
21
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
32
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
43
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
54
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
6-
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
7-
github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
8-
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
9-
github.com/stretchr/testify v1.7.4 h1:wZRexSlwd7ZXfKINDLsO4r7WBt3gTKONc6K/VesHvHM=
10-
github.com/stretchr/testify v1.7.4/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
5+
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
6+
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
117
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
128
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
13-
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
149
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
1510
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

0 commit comments

Comments
 (0)