Skip to content

Commit 3575bdb

Browse files
authored
Ensure sentence overlap is considered in SentenceBoundaryChunkingSettings equals/hashCode (elastic#126250)
1 parent e85a38b commit 3575bdb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/chunking/SentenceBoundaryChunkingSettings.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -147,12 +147,12 @@ public boolean equals(Object o) {
147147
if (this == o) return true;
148148
if (o == null || getClass() != o.getClass()) return false;
149149
SentenceBoundaryChunkingSettings that = (SentenceBoundaryChunkingSettings) o;
150-
return Objects.equals(maxChunkSize, that.maxChunkSize);
150+
return Objects.equals(maxChunkSize, that.maxChunkSize) && Objects.equals(sentenceOverlap, that.sentenceOverlap);
151151
}
152152

153153
@Override
154154
public int hashCode() {
155-
return Objects.hash(maxChunkSize);
155+
return Objects.hash(maxChunkSize, sentenceOverlap);
156156
}
157157

158158
@Override

0 commit comments

Comments
 (0)