Skip to content

Re-optimize cases collection: parametrized cases do not always need to be turned into fixtures #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smarie opened this issue Dec 16, 2020 · 2 comments

Comments

@smarie
Copy link
Owner

smarie commented Dec 16, 2020

As noted in #158 , since 3.0.0 all parametrized cases are turned into fixtures. This ensures solid support for all kind of complex nesting and fixtures depenencies. However maybe we could simplify this when a case is parametrized but the parametrization does not contain any fixture reference ? In that case we still need to make sure that if there are lazy values, the "lazyness" needs to be intelligently combined. OR, an alternative is to only simplify when there are no fixture refs NOR lazy values.

@smarie
Copy link
Owner Author

smarie commented Dec 18, 2020

Note that #170 may solve this by supporting parametrized lazy_values

@smarie smarie added performance and removed enhancement New feature or request labels Apr 30, 2021
@smarie
Copy link
Owner Author

smarie commented May 21, 2021

One aspect that needs not to be forgotten is how easy the parameter of a case function can be accessed afterwards. With the current situation (parametrized cases = fixtures) it is relatively easy, see #211 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant