[dsn] add more octal tests

Author: makasim

pkg/dsn/Dsn.php

@@ -172,7 +172,7 @@ public function getOctal(string $name, int $default = null): ?int
             return $default;
         }
 
-        if (false == preg_match('/^[\+\-]?[0-9]*$/', $value)) {
+        if (false == preg_match('/^0[\+\-]?[0-7]*$/', $value)) {
             throw InvalidQueryParameterTypeException::create($name, 'integer');
         }
 

pkg/dsn/Tests/DsnTest.php

@@ -134,6 +134,33 @@ public function testThrowIfQueryParameterNotInt()
         $dsn->getInt('aName');
     }
 
+    public function testThrowIfQueryParameterNotOctalButString()
+    {
+        $dsn = new Dsn('foo:?aName=notInt');
+
+        $this->expectException(InvalidQueryParameterTypeException::class);
+        $this->expectExceptionMessage('The query parameter "aName" has invalid type. It must be "integer"');
+        $dsn->getOctal('aName');
+    }
+
+    public function testThrowIfQueryParameterNotOctalButDecimal()
+    {
+        $dsn = new Dsn('foo:?aName=123');
+
+        $this->expectException(InvalidQueryParameterTypeException::class);
+        $this->expectExceptionMessage('The query parameter "aName" has invalid type. It must be "integer"');
+        $dsn->getOctal('aName');
+    }
+
+    public function testThrowIfQueryParameterInvalidOctal()
+    {
+        $dsn = new Dsn('foo:?aName=0128');
+
+        $this->expectException(InvalidQueryParameterTypeException::class);
+        $this->expectExceptionMessage('The query parameter "aName" has invalid type. It must be "integer"');
+        $dsn->getOctal('aName');
+    }
+
     /**
      * @dataProvider provideFloatQueryParameters
      */