Skip to content

Commit 2b5dfb9

Browse files
fix: check the type of the initial packet
Before this fix, the client could mark the polling transport as open even though the handshake packet was not received properly (for example, after a parsing error). See also: socketio/engine.io-client@1c8cba8
1 parent dfe65e3 commit 2b5dfb9

File tree

1 file changed

+1
-1
lines changed
  • src/main/java/io/socket/engineio/client/transports

1 file changed

+1
-1
lines changed

Diff for: src/main/java/io/socket/engineio/client/transports/Polling.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private void _onData(Object data) {
114114
Parser.DecodePayloadCallback callback = new Parser.DecodePayloadCallback() {
115115
@Override
116116
public boolean call(Packet packet, int index, int total) {
117-
if (self.readyState == ReadyState.OPENING) {
117+
if (self.readyState == ReadyState.OPENING && Packet.OPEN.equals(packet.type)) {
118118
self.onOpen();
119119
}
120120

0 commit comments

Comments
 (0)