Skip to content

Commit 6f065b7

Browse files
Jacek Mleczekdarrachequesne
Jacek Mleczek
authored andcommitted
fix: handle responses without content type (#101)
This fixes NullPointerException when response doesn't have content type. Exception stack trace: ``` java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String okhttp3.MediaType.toString()' on a null object reference at io.socket.engineio.client.transports.PollingXHR$Request.onLoad(PollingXHR.java:271) at io.socket.engineio.client.transports.PollingXHR$Request.access$700(PollingXHR.java:148) at io.socket.engineio.client.transports.PollingXHR$Request$1.onResponse(PollingXHR.java:232) at okhttp3.RealCall$AsyncCall.execute(RealCall.java:141) at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) at java.lang.Thread.run(Thread.java:764) ```
1 parent 5c65197 commit 6f065b7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: src/main/java/io/socket/engineio/client/transports/PollingXHR.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,10 @@ private void onResponseHeaders(Map<String, List<String>> headers) {
268268

269269
private void onLoad() {
270270
ResponseBody body = response.body();
271-
String contentType = body.contentType().toString();
271+
MediaType mediaType = body.contentType();
272272

273273
try {
274-
if (BINARY_CONTENT_TYPE.equalsIgnoreCase(contentType)) {
274+
if (mediaType != null && BINARY_CONTENT_TYPE.equalsIgnoreCase(mediaType.toString())) {
275275
this.onData(body.bytes());
276276
} else {
277277
this.onData(body.string());

0 commit comments

Comments
 (0)