Skip to content

Commit ed87609

Browse files
fix: fix the ES module wrapper
The package does not have a default export, so importing it from a project using ES modules would break in some cases. > Cannot destructure property 'Server' of '_engineIo.default' Related: #657
1 parent bc98bf1 commit ed87609

File tree

5 files changed

+27
-5
lines changed

5 files changed

+27
-5
lines changed

examples/esm-import/README.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
## How to use
2+
3+
```
4+
$ npm link ../..
5+
$ node index.js
6+
```

examples/esm-import/index.js

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import { Server } from "engine.io";
2+
3+
console.log(Server);

examples/esm-import/package.json

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"name": "esm-import",
3+
"version": "0.0.1",
4+
"private": true,
5+
"type": "module"
6+
}

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@
6262
"test:compat-v3": "EIO_CLIENT=3 mocha --exit",
6363
"test:eiows": "EIO_WS_ENGINE=eiows mocha --exit",
6464
"test:uws": "EIO_WS_ENGINE=uws mocha --exit",
65-
"format:check": "prettier --check \"lib/**/*.ts\" \"test/**/*.js\"",
66-
"format:fix": "prettier --write \"lib/**/*.ts\" \"test/**/*.js\"",
65+
"format:check": "prettier --check \"wrapper.mjs\" \"lib/**/*.ts\" \"test/**/*.js\"",
66+
"format:fix": "prettier --write \"wrapper.mjs\" \"lib/**/*.ts\" \"test/**/*.js\"",
6767
"prepack": "npm run compile"
6868
},
6969
"repository": {

wrapper.mjs

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1-
import lib from "./build/engine.io.js";
2-
3-
export const { Server, Socket, Transport, transports, listen, attach, parser, protocol } = lib;
1+
export {
2+
Server,
3+
Socket,
4+
Transport,
5+
transports,
6+
listen,
7+
attach,
8+
parser,
9+
protocol,
10+
} from "./build/engine.io.js";

0 commit comments

Comments
 (0)