Converted for-in loops to for+getOwnPropertyNames loops

Author: darrachequesne

index.js

@@ -81,12 +81,11 @@ Adapter.prototype.del = function(id, room, fn){
 Adapter.prototype.delAll = function(id, fn){
   var rooms = this.sids[id];
   if (rooms) {
-    for (var room in rooms) {
-      if (rooms.hasOwnProperty(room)) {
-        delete this.rooms[room][id];
-      }
+    for (var i = 0, keys = Object.getOwnPropertyNames(rooms), l = keys.length; i < l; ++i) {
+      var room = keys[i];
+      delete this.rooms[room][id];
 
-      if (this.rooms.hasOwnProperty(room) && !Object.keys(this.rooms[room]).length) {
+      if (!Object.keys(this.rooms[room]).length) {
         delete this.rooms[room];
       }
     }
@@ -124,27 +123,25 @@ Adapter.prototype.broadcast = function(packet, opts){
   packet.nsp = this.nsp.name;
   this.encoder.encode(packet, function(encodedPackets) {
     if (Object.keys(rooms).length) {
-      for (var name in rooms) {
-        var room = self.rooms[rooms[name]];
+      for (var i = 0, keys = Object.getOwnPropertyNames(rooms), l = keys.length; i < l; ++i) {
+        var room = self.rooms[rooms[keys[i]]];
         if (!room) continue;
-        for (var id in room) {
-          if (room.hasOwnProperty(id)) {
-            if (ids[id] || except[id]) continue;
-            socket = self.nsp.connected[id];
-            if (socket) {
-              socket.packet(encodedPackets, packetOpts);
-              ids[id] = true;
-            }
+        for (var j = 0, keys2 = Object.getOwnPropertyNames(room), k = keys2.length; j < k; ++j) {
+          var id = keys2[j];
+          if (ids[id] || except[id]) continue;
+          socket = self.nsp.connected[id];
+          if (socket) {
+            socket.packet(encodedPackets, packetOpts);
+            ids[id] = true;
           }
         }
       }
     } else {
-      for (var id in self.sids) {
-        if (self.sids.hasOwnProperty(id)) {
-          if (except[id]) continue;
-          socket = self.nsp.connected[id];
-          if (socket) socket.packet(encodedPackets, packetOpts);
-        }
+      for (var i = 0, keys = Object.getOwnPropertyNames(self.sids), l = keys.length; i < l; ++i) {
+        var id = keys[i];
+        if (except[id]) continue;
+        socket = self.nsp.connected[id];
+        if (socket) socket.packet(encodedPackets, packetOpts);
       }
     }
   });
@@ -171,26 +168,24 @@ Adapter.prototype.clients = function(rooms, fn){
   var socket;
 
   if (Object.keys(rooms).length) {
-    for (var name in rooms) {
-      var room = self.rooms[rooms[name]];
+    for (var i = 0, keys = Object.getOwnPropertyNames(rooms), l = keys.length; i < l; ++i) {
+      var room = self.rooms[rooms[keys[i]]];
       if (!room) continue;
-      for (var id in room) {
-        if (room.hasOwnProperty(id)) {
-          if (ids[id]) continue;
-          socket = self.nsp.connected[id];
-          if (socket) {
-            sids.push(id);
-            ids[id] = true;
-          }
+      for (var j = 0, keys2 = Object.getOwnPropertyNames(room), k = keys2.length; j < k; ++j) {
+        var id = keys2[j];
+        if (ids[id]) continue;
+        socket = self.nsp.connected[id];
+        if (socket) {
+          sids.push(id);
+          ids[id] = true;
         }
       }
     }
   } else {
-    for (var id in self.sids) {
-      if (self.sids.hasOwnProperty(id)) {
-        socket = self.nsp.connected[id];
-        if (socket) sids.push(id);
-      }
+    for (var i = 0, keys = Object.getOwnPropertyNames(self.sids), l = keys.length; i < l; ++i) {
+      var id = keys[i];
+      socket = self.nsp.connected[id];
+      if (socket) sids.push(id);
     }
   }