Skip to content

Commit 9ae1f17

Browse files
committed
Modernize logging.
1 parent 02464cf commit 9ae1f17

File tree

11 files changed

+25
-25
lines changed

11 files changed

+25
-25
lines changed

bake/async/http/h2spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def server
3030

3131
container = Async::Container.new
3232

33-
Console.logger.info(self){"Starting server..."}
33+
Console.info(self){"Starting server..."}
3434

3535
container.run(count: 1) do
3636
server = Async::HTTP::Server.for(endpoint, protocol: Async::HTTP::Protocol::HTTP2, scheme: "https") do |request|

examples/download/chunked.rb

+6-6
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
headers = {"user-agent" => "curl/7.69.1", "accept" => "*/*"}
2121

2222
file = File.open("products.csv", "w")
23-
Console.logger.info(self) {"Saving download to #{Dir.pwd}"}
23+
Console.info(self) {"Saving download to #{Dir.pwd}"}
2424

2525
begin
2626
response = client.head(endpoint.path, headers)
@@ -39,7 +39,7 @@
3939
response&.close
4040
end
4141

42-
Console.logger.info(self) {"Content length: #{content_length/(1024**2)}MiB"}
42+
Console.info(self) {"Content length: #{content_length/(1024**2)}MiB"}
4343

4444
parts = []
4545
offset = 0
@@ -56,7 +56,7 @@
5656
offset += chunk_size
5757
end
5858

59-
Console.logger.info(self) {"Breaking download into #{parts.size} parts..."}
59+
Console.info(self) {"Breaking download into #{parts.size} parts..."}
6060

6161
semaphore = Async::Semaphore.new(8)
6262
barrier = Async::Barrier.new(parent: semaphore)
@@ -65,21 +65,21 @@
6565
barrier.async do
6666
part = parts.shift
6767

68-
Console.logger.info(self) {"Issuing range request range: bytes=#{part.min}-#{part.max}"}
68+
Console.info(self) {"Issuing range request range: bytes=#{part.min}-#{part.max}"}
6969

7070
response = client.get(endpoint.path, [
7171
["range", "bytes=#{part.min}-#{part.max-1}"],
7272
*headers
7373
])
7474

7575
if response.success?
76-
Console.logger.info(self) {"Got response: #{response}... writing data for #{part}."}
76+
Console.info(self) {"Got response: #{response}... writing data for #{part}."}
7777
written = file.pwrite(response.read, part.min)
7878

7979
amount += written
8080

8181
duration = Async::Clock.now - start_time
82-
Console.logger.info(self) {"Rate: #{((amount.to_f/(1024**2))/duration).round(2)}MiB/s"}
82+
Console.info(self) {"Rate: #{((amount.to_f/(1024**2))/duration).round(2)}MiB/s"}
8383
end
8484
end
8585
end

examples/google/search.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
class Google < Protocol::HTTP::Middleware
1616
def search(term)
17-
Console.logger.info(self) {"Searching for #{term}..."}
17+
Console.info(self) {"Searching for #{term}..."}
1818

1919
self.get("/search?q=#{term}", {"user-agent" => "Hi Google!"})
2020
end
@@ -40,10 +40,10 @@ def search(term)
4040
end
4141
end.map(&:wait).to_h
4242

43-
Console.logger.info(self, name: "counts") {counts}
43+
Console.info(self, name: "counts") {counts}
4444
end
4545

46-
Console.logger.info(self, name: "duration") {duration}
46+
Console.info(self, name: "duration") {duration}
4747
ensure
4848
google.close
4949
end

examples/licenses/list.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def fetch_rubygem_license(name, version)
6363
rescue RateLimitingError
6464
response.finish
6565

66-
Console.logger.warn(name) {"Rate limited..."}
66+
Console.warn(name) {"Rate limited..."}
6767
Async::Task.current.sleep(1.0)
6868

6969
retry

examples/stream/stop.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@
1616
connection = response.connection
1717

1818
response.each do |chunk|
19-
Console.logger.info(response) {chunk}
19+
Console.info(response) {chunk}
2020
end
2121
ensure
22-
Console.logger.info(response) {"Closing response..."}
22+
Console.info(response) {"Closing response..."}
2323
response&.close
2424
end
2525

2626
parent.sleep(5)
2727

28-
Console.logger.info(parent) {"Killing #{child}..."}
28+
Console.info(parent) {"Killing #{child}..."}
2929
child.stop
3030
ensure
3131
internet&.close

lib/async/http/client.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def self.open(*arguments, **options, &block)
8181

8282
def close
8383
while @pool.busy?
84-
Console.logger.warn(self) {"Waiting for #{@protocol} pool to drain: #{@pool}"}
84+
Console.warn(self) {"Waiting for #{@protocol} pool to drain: #{@pool}"}
8585
@pool.wait
8686
end
8787

@@ -164,7 +164,7 @@ def make_pool(**options)
164164
self.assign_default_tags(options[:tags] ||= {})
165165

166166
Async::Pool::Controller.wrap(**options) do
167-
Console.logger.debug(self) {"Making connection to #{@endpoint.inspect}"}
167+
Console.debug(self) {"Making connection to #{@endpoint.inspect}"}
168168

169169
@protocol.client(@endpoint.connect)
170170
end

lib/async/http/protocol/http1/client.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def closed(error = nil)
3232

3333
# Used by the client to send requests to the remote server.
3434
def call(request, task: Task.current)
35-
Console.logger.debug(self) {"#{request.method} #{request.path} #{request.headers.inspect}"}
35+
Console.debug(self) {"#{request.method} #{request.path} #{request.headers.inspect}"}
3636

3737
# Mark the start of the trailers:
3838
trailer = request.headers.trailer!

lib/async/http/protocol/http2/stream.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def process_headers(frame)
6565
@input.close_write
6666
end
6767
rescue ::Protocol::HTTP2::HeaderError => error
68-
Console.logger.debug(self, error)
68+
Console.debug(self, "Error while processing headers!", error: error)
6969

7070
send_reset_stream(error.code)
7171
end

lib/async/http/protocol/https.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def self.protocol_for(peer)
2525
# alpn_protocol is only available if openssl v1.0.2+
2626
name = peer.alpn_protocol
2727

28-
Console.logger.debug(self) {"Negotiating protocol #{name.inspect}..."}
28+
Console.debug(self) {"Negotiating protocol #{name.inspect}..."}
2929

3030
if protocol = HANDLERS[name]
3131
return protocol

lib/async/http/server.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ def to_json(...)
4545
def accept(peer, address, task: Task.current)
4646
connection = @protocol.server(peer)
4747

48-
Console.logger.debug(self) {"Incoming connnection from #{address.inspect} to #{@protocol}"}
48+
Console.debug(self) {"Incoming connnection from #{address.inspect} to #{@protocol}"}
4949

5050
connection.each do |request|
5151
# We set the default scheme unless it was otherwise specified.
5252
# https://tools.ietf.org/html/rfc7230#section-5.5
5353
request.scheme ||= self.scheme
5454

55-
# Console.logger.debug(self) {"Incoming request from #{address.inspect}: #{request.method} #{request.path}"}
55+
# Console.debug(self) {"Incoming request from #{address.inspect}: #{request.method} #{request.path}"}
5656

5757
# If this returns nil, we assume that the connection has been hijacked.
5858
self.call(request)

test/async/http/proxy.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,11 @@
128128
host, port = request.authority.split(":", 2)
129129
endpoint = IO::Endpoint.tcp(host, port)
130130

131-
Console.logger.debug(self) {"Making connection to #{endpoint}..."}
131+
Console.debug(self) {"Making connection to #{endpoint}..."}
132132

133133
Async::HTTP::Body::Hijack.response(request, 200, {}) do |stream|
134134
upstream = ::IO::Stream::Buffered.wrap(endpoint.connect)
135-
Console.logger.debug(self) {"Connected to #{upstream}..."}
135+
Console.debug(self) {"Connected to #{upstream}..."}
136136

137137
reader = Async do |task|
138138
task.annotate "Upstream reader."
@@ -142,7 +142,7 @@
142142
stream.flush
143143
end
144144
ensure
145-
Console.logger.debug(self) {"Finished reading from upstream..."}
145+
Console.debug(self) {"Finished reading from upstream..."}
146146
stream.close_write
147147
end
148148

@@ -154,7 +154,7 @@
154154
upstream.flush
155155
end
156156
ensure
157-
Console.logger.debug(self) {"Finished writing to upstream..."}
157+
Console.debug(self) {"Finished writing to upstream..."}
158158
upstream.close_write
159159
end
160160

0 commit comments

Comments
 (0)