Fix: Label empty body functions (fixes eslint#92)

There are rules in eslint that expect FunctionExpression
nodes to contain a body. We should not produce an invalid
estree node if we use the estree node types.

Author: soda0289

Diff for: lib/ast-converter.js

@@ -879,6 +879,10 @@ module.exports = function(ast, extra) {
                     }
                 }
 
+                if (!node.body) {
+                    functionDeclarationType = "TSEmptyBodyFunctionDeclaration";
+                }
+
                 /**
                  * Prefix FunctionDeclarations within TypeScript namespaces with "TS"
                  */
@@ -1074,6 +1078,7 @@ module.exports = function(ast, extra) {
                 // TODO: double-check that these positions are correct
                 var methodLoc = ast.getLineAndCharacterOfPosition(node.name.end + 1),
                     nodeIsMethod = (node.kind === SyntaxKind.MethodDeclaration),
+                    isEmptyBody = !(node.body),
                     method = {
                         type: "FunctionExpression",
                         id: null,
@@ -1127,16 +1132,24 @@ module.exports = function(ast, extra) {
                     /**
                      * TypeScript class methods can be defined as "abstract"
                      */
-                    var methodDefinitionType = "MethodDefinition";
+                    var methodDefinitionType = "MethodDefinition",
+                        isAbstractMethod = false;
                     if (node.modifiers && node.modifiers.length) {
-                        var isAbstractMethod = node.modifiers.some(function(modifier) {
+                        isAbstractMethod = node.modifiers.some(function(modifier) {
                             return modifier.kind === ts.SyntaxKind.AbstractKeyword;
                         });
                         if (isAbstractMethod) {
                             methodDefinitionType = "TSAbstractMethodDefinition";
                         }
                     }
 
+                    if (isEmptyBody) {
+                        if (!isAbstractMethod) {
+                            methodDefinitionType = "TSEmptyBodyMethodDefinition";
+                        }
+                        method.type = "TSEmptyBodyFunctionExpression";
+                    }
+
                     assign(result, {
                         type: methodDefinitionType,
                         key: convertChild(node.name),
@@ -1167,6 +1180,7 @@ module.exports = function(ast, extra) {
                 var constructorIsStatic = Boolean(node.flags & ts.NodeFlags.Static),
                     firstConstructorToken = constructorIsStatic ? ts.findNextToken(node.getFirstToken(), ast) : node.getFirstToken(),
                     constructorLoc = ast.getLineAndCharacterOfPosition(node.parameters.pos - 1),
+                    constructorIsEmptyBody = !(node.body),
                     constructor = {
                         type: "FunctionExpression",
                         id: null,
@@ -1230,8 +1244,14 @@ module.exports = function(ast, extra) {
                     };
                 }
 
+                var constructorMethodDefinitionType = "MethodDefinition";
+                if (constructorIsEmptyBody) {
+                    constructorMethodDefinitionType = "TSEmptyBodyMethodDefinition";
+                    constructor.type = "TSEmptyBodyFunctionExpression";
+                }
+
                 assign(result, {
-                    type: "MethodDefinition",
+                    type: constructorMethodDefinitionType,
                     key: constructorKey,
                     value: constructor,
                     computed: constructorIsComputed,

Diff for: tests/fixtures/typescript/basics/abstract-class-with-abstract-method.result.js

@@ -89,7 +89,7 @@ module.exports = {
                                 "name": "createSocket"
                             },
                             "value": {
-                                "type": "FunctionExpression",
+                                "type": "TSEmptyBodyFunctionExpression",
                                 "id": null,
                                 "generator": false,
                                 "expression": false,

Diff for: tests/fixtures/typescript/basics/declare-function.result.js

@@ -16,7 +16,7 @@ module.exports = {
     },
     "body": [
         {
-            "type": "DeclareFunction",
+            "type": "TSEmptyBodyFunctionDeclaration",
             "range": [
                 0,
                 42
@@ -344,4 +344,4 @@ module.exports = {
             }
         }
     ]
-};
+};