[Pylint] py_version and is_check_enabled edits (Azure#33743)

l0lawrence · kristapratico · sofiar-msft · commit 1d7d57f5d839 · 2024-02-16T16:35:25.000-06:00
* py version improvement

* conflict

* conflict 2

* add py-version to pylintrc

---------

Co-authored-by: Krista Pratico &lt;krpratic@microsoft.com&gt;
diff --git a/eng/pylintrc b/eng/pylintrc
@@ -1,4 +1,5 @@
 [MASTER]
+py-version=3.8
 ignore-patterns=test_*,conftest,setup
 reports=no
 
diff --git a/eng/tox/run_pylint.py b/eng/tox/run_pylint.py
@@ -72,7 +72,7 @@
         logging.error(
             "{} exited with linting error {}. Please see this link for more information https://aka.ms/azsdk/python/pylint-guide".format(pkg_details.name, e.returncode)
         )
-        if args.next and in_ci() and is_check_enabled(args.target_package, "pylint"):
+        if args.next and in_ci():
             from gh_tools.vnext_issue_creator import create_vnext_issue
             create_vnext_issue(pkg_details.name, "pylint")
 
diff --git a/eng/tox/tox.ini b/eng/tox/tox.ini
@@ -77,7 +77,6 @@ commands =
 
 [testenv:pylint]
 description=Lints a package with pylint (version {[testenv:pylint]pylint_version})
-basepython = python38
 pylint_version=2.15.8
 skipsdist = true
 skip_install = true
@@ -102,7 +101,6 @@ commands =
 
 [testenv:next-pylint]
 description=Lints a package with pylint (version {[testenv:next-pylint]pylint_version})
-basepython = python38
 pylint_version=3.0.3
 skipsdist = true
 skip_install = true
diff --git a/pylintrc b/pylintrc
@@ -1,4 +1,5 @@
 [MASTER]
+py-version=3.8
 ignore-patterns=test_*,conftest,setup
 reports=no
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`[MASTER]`
	`2`	`+py-version=3.8`
`2`	`3`	`ignore-patterns=test_*,conftest,setup`
`3`	`4`	`reports=no`
`4`	`5`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@`
`72`	`72`	`logging.error(`
`73`	`73`	`"{} exited with linting error {}. Please see this link for more information https://aka.ms/azsdk/python/pylint-guide".format(pkg_details.name, e.returncode)`
`74`	`74`	`)`
`75`		`- if args.next and in_ci() and is_check_enabled(args.target_package, "pylint"):`
	`75`	`+ if args.next and in_ci():`
`76`	`76`	`from gh_tools.vnext_issue_creator import create_vnext_issue`
`77`	`77`	`create_vnext_issue(pkg_details.name, "pylint")`
`78`	`78`