Skip to content

Commit 5377d49

Browse files
pvanecksofiar-msft
authored andcommitted
[Identity Broker] Minimum Python bump (Azure#34186)
- Bumped minimum Python version - Removed reference to `allow_broker` kwarg we no longer use - Fixed variable in README code snippet Signed-off-by: Paul Van Eck <[email protected]>
1 parent 112f5ae commit 5377d49

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

sdk/identity/azure-identity-broker/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Release History
22

3-
## 1.0.1 (Unreleased)
3+
## 1.1.0 (Unreleased)
44

55
### Features Added
66

@@ -10,6 +10,8 @@
1010

1111
### Other Changes
1212

13+
- Python 3.7 is no longer supported. Please use Python version 3.8 or later.
14+
1315
## 1.0.0 (2023-11-07)
1416

1517
### Features Added

sdk/identity/azure-identity-broker/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ from azure.storage.blob import BlobServiceClient
5353
current_window_handle = win32gui.GetForegroundWindow()
5454

5555
credential = InteractiveBrowserBrokerCredential(parent_window_handle=current_window_handle)
56-
client = BlobServiceClient(account_url, credential=default_credential)
56+
client = BlobServiceClient(account_url, credential=credential)
5757
```
5858

5959
## Troubleshooting

sdk/identity/azure-identity-broker/azure/identity/broker/_browser.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,8 @@ class InteractiveBrowserBrokerCredential(_InteractiveBrowserCredential):
3535
may still log in with a different username.
3636
:paramtype cache_persistence_options: ~azure.identity.TokenCachePersistenceOptions
3737
:keyword int timeout: seconds to wait for the user to complete authentication. Defaults to 300 (5 minutes).
38-
:keyword int parent_window_handle: If your app is a GUI app running on a modern Windows system,
39-
and your app opts in to use broker via `allow_broker`, you are required to also provide its window handle,
40-
so that the sign in UI window will properly pop up on top of your window.
38+
:keyword int parent_window_handle: If your app is a GUI app running on a modern Windows system, you are required to
39+
also provide its window handle so that the sign in UI window will properly pop up on top of your window.
4140
:keyword bool enable_msa_passthrough: Determines whether Microsoft Account (MSA) passthrough is enabled. Note, this
4241
is only needed for select legacy first-party applications. Defaults to False.
4342
:keyword bool disable_instance_discovery: Determines whether or not instance discovery is performed when attempting

sdk/identity/azure-identity-broker/azure/identity/broker/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
# Copyright (c) Microsoft Corporation.
33
# Licensed under the MIT License.
44
# ------------------------------------
5-
VERSION = "1.0.1"
5+
VERSION = "1.1.0"

sdk/identity/azure-identity-broker/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
"Programming Language :: Python",
4646
"Programming Language :: Python :: 3 :: Only",
4747
"Programming Language :: Python :: 3",
48-
"Programming Language :: Python :: 3.7",
4948
"Programming Language :: Python :: 3.8",
5049
"Programming Language :: Python :: 3.9",
5150
"Programming Language :: Python :: 3.10",
@@ -61,7 +60,7 @@
6160
package_data={
6261
"pytyped": ["py.typed"],
6362
},
64-
python_requires=">=3.7",
63+
python_requires=">=3.8",
6564
install_requires=[
6665
"azure-identity<2.0.0,>=1.14.0",
6766
"msal[broker]>=1.25,<2",

0 commit comments

Comments
 (0)