Skip to content

Commit 590f55f

Browse files
added some testing exceptions so pylint can run its latest versions
1 parent 7f4774c commit 590f55f

File tree

6 files changed

+15
-11
lines changed

6 files changed

+15
-11
lines changed

SoftLayer/CLI/core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from SoftLayer import consts
2222

2323
# pylint: disable=too-many-public-methods, broad-except, unused-argument
24-
# pylint: disable=redefined-builtin, super-init-not-called
24+
# pylint: disable=redefined-builtin, super-init-not-called, arguments-differ
2525

2626
START_TIME = time.time()
2727
DEBUG_LOGGING_MAP = {

SoftLayer/CLI/dns/record_list.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from SoftLayer.CLI import environment
88
from SoftLayer.CLI import formatting
99
from SoftLayer.CLI import helpers
10-
# pylint: disable=redefined-builtin
10+
# pylint: disable=redefined-builtin, redefined-argument-from-local
1111

1212

1313
@click.command()
@@ -37,13 +37,13 @@ def cli(env, zone, data, record, ttl, type):
3737
ttl=ttl,
3838
data=data)
3939

40-
for record in records:
40+
for the_record in records:
4141
table.add_row([
42-
record['id'],
43-
record['host'],
44-
record['type'].upper(),
45-
record['ttl'],
46-
record['data']
42+
the_record['id'],
43+
the_record['host'],
44+
the_record['type'].upper(),
45+
the_record['ttl'],
46+
the_record['data']
4747
])
4848

4949
env.fout(table)

SoftLayer/CLI/formatting.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
77
:license: MIT, see LICENSE for more details.
88
"""
9-
# pylint: disable=E0202
9+
# pylint: disable=E0202, consider-merging-isinstance, arguments-differ
1010
import collections
1111
import json
1212
import os

SoftLayer/CLI/template.py

+2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
88
:license: MIT, see LICENSE for more details.
99
"""
10+
11+
# pylint: disable=redefined-argument-from-local
1012
import os.path
1113

1214
from SoftLayer import utils

SoftLayer/testing/xmlrpc.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from SoftLayer import transports
1515
from SoftLayer import utils
1616

17-
# pylint: disable=invalid-name, broad-except
17+
# pylint: disable=invalid-name, broad-except, arguments-differ
1818

1919

2020
class TestServer(six.moves.BaseHTTPServer.HTTPServer):

tox.ini

+3-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ basepython = python2.7
2121
deps =
2222
-r{toxinidir}/tools/test-requirements.txt
2323
hacking
24-
pylint==1.6.5
24+
pylint
2525
commands =
2626
flake8 SoftLayer tests
2727

@@ -33,6 +33,8 @@ commands =
3333
-d star-args \
3434
-d redefined-variable-type \
3535
-d locally-disabled \
36+
-d no-else-return \
37+
-d len-as-condition \
3638
--max-args=20 \
3739
--max-branches=20 \
3840
--max-statements=60 \

0 commit comments

Comments
 (0)