Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: softlayer/softlayer-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.3
Choose a base ref
...
head repository: softlayer/softlayer-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.4
Choose a head ref
  • 6 commits
  • 7 files changed
  • 3 contributors

Commits on Jun 25, 2015

  1. Resolves unicode issues with image listing

    Kevin McDonald committed Jun 25, 2015
    Copy the full SHA
    5cccca9 View commit details

Commits on Jun 30, 2015

  1. Remove userData from mask

    parente committed Jun 30, 2015

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    737e58d View commit details
  2. Merge pull request #569 from parente/userData-gone

    Remove userData from mask
    sudorandom committed Jun 30, 2015
    Copy the full SHA
    5c8d5a8 View commit details
  3. Merge pull request #567 from sudorandom/issue-566

    Resolves unicode issues with image listing
    sudorandom committed Jun 30, 2015
    Copy the full SHA
    3ad50d7 View commit details
  4. Version Bump to v4.0.4

    Kevin McDonald committed Jun 30, 2015
    Copy the full SHA
    5012de4 View commit details
  5. Copy the full SHA
    7d3772b View commit details
Showing with 23 additions and 6 deletions.
  1. +6 −0 CHANGELOG
  2. +1 −1 SoftLayer/CLI/formatting.py
  3. +1 −1 SoftLayer/consts.py
  4. +0 −1 SoftLayer/managers/vs.py
  5. +12 −0 SoftLayer/tests/CLI/helper_tests.py
  6. +2 −2 docs/conf.py
  7. +1 −1 setup.py
6 changes: 6 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
4.0.4

* Fixes bug with pulling the userData property for the virtual server detail

* Fixes a class of bugs invloving unicode from the API

4.0.3

* Fixes bug with `slcli vs ready` command
2 changes: 1 addition & 1 deletion SoftLayer/CLI/formatting.py
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ def format_output(data, fmt='table'): # pylint: disable=R0911,R0912
# responds to .formatted
if hasattr(data, 'formatted'):
if fmt == 'table':
return str(data.formatted)
return data.formatted

# responds to .separator
if hasattr(data, 'separator'):
2 changes: 1 addition & 1 deletion SoftLayer/consts.py
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
:license: MIT, see LICENSE for more details.
"""
VERSION = 'v4.0.3'
VERSION = 'v4.0.4'
API_PUBLIC_ENDPOINT = 'https://api.softlayer.com/xmlrpc/v3.1/'
API_PRIVATE_ENDPOINT = 'https://api.service.softlayer.com/xmlrpc/v3.1/'
API_PUBLIC_ENDPOINT_REST = 'https://api.softlayer.com/rest/v3.1/'
1 change: 0 additions & 1 deletion SoftLayer/managers/vs.py
Original file line number Diff line number Diff line change
@@ -191,7 +191,6 @@ def get_instance(self, instance_id, **kwargs):
'blockDevices',
'blockDeviceTemplateGroup[id, name, globalIdentifier]',
'postInstallScriptUri',
'userData',
'''operatingSystem[passwords[username,password],
softwareLicense.softwareDescription[
manufacturer,name,version,
12 changes: 12 additions & 0 deletions SoftLayer/tests/CLI/helper_tests.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# -*- coding: utf-8 -*-
"""
SoftLayer.tests.CLI.helper_tests
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -357,6 +358,17 @@ def test_format_output_python_keyvaluetable(self):
ret = formatting.format_output(t, 'python')
self.assertEqual({'nothing': None}, ret)

def test_format_output_unicode(self):
t = formatting.format_output('☃', 'raw')
self.assertEqual('☃', t)

item = formatting.FormattedItem('raw ☃', '☃')
t = formatting.format_output(item)
self.assertEqual('☃', t)

t = formatting.format_output(item, 'raw')
self.assertEqual('raw ☃', t)


class TestTemplateArgs(testing.TestCase):

4 changes: 2 additions & 2 deletions docs/conf.py
Original file line number Diff line number Diff line change
@@ -55,9 +55,9 @@
# built documents.
#
# The short X.Y version.
version = '4.0.3'
version = '4.0.4'
# The full version, including alpha/beta/rc tags.
release = '4.0.3'
release = '4.0.4'

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@

setup(
name='SoftLayer',
version='4.0.3',
version='4.0.4',
description=DESCRIPTION,
long_description=LONG_DESCRIPTION,
author='SoftLayer Technologies, Inc.',