Skip to content

"slcli firewall cancle" failed #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarikoTagawa opened this issue Jun 27, 2017 · 2 comments
Closed

"slcli firewall cancle" failed #835

MarikoTagawa opened this issue Jun 27, 2017 · 2 comments

Comments

@MarikoTagawa
Copy link

Please triple-check to make sure that you have properly masked out user credentials like usernames, passwords and API keys before submitting your issue

Expected Behavior

Cancel the specified firewall

Actual Behavior

Got the following error and failed.

$ slcli firewall cancel "vlan:8003"
This action will cancel a firewall from your account. Continue? [y/N]: y
An unexpected error has occured:
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/SoftLayer-5.2.0-py2.7.egg/SoftLayer/CLI/core.py", line 163, in main
cli.main(**kwargs)
File "/Library/Python/2.7/site-packages/click/core.py", line 680, in main
rv = self.invoke(ctx)
File "/Library/Python/2.7/site-packages/click/core.py", line 1027, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Library/Python/2.7/site-packages/click/core.py", line 1027, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Library/Python/2.7/site-packages/click/core.py", line 873, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Library/Python/2.7/site-packages/click/core.py", line 508, in invoke
return callback(*args, **kwargs)
File "/Library/Python/2.7/site-packages/click/decorators.py", line 63, in new_func
return ctx.invoke(f, obj, *args[1:], **kwargs)
File "/Library/Python/2.7/site-packages/click/core.py", line 508, in invoke
return callback(*args, **kwargs)
File "/Library/Python/2.7/site-packages/SoftLayer-5.2.0-py2.7.egg/SoftLayer/CLI/firewall/cancel.py", line 30, in cli
mgr.cancel_firewall(firewall_id, dedicated=True)
File "/Library/Python/2.7/site-packages/SoftLayer-5.2.0-py2.7.egg/SoftLayer/managers/firewall.py", line 90, in cancel_firewall
billing_id = fwl_billing['billingItem']['id']
KeyError: 'billingItem'

Feel free to report this error as it is likely a bug:
https://github.com/softlayer/softlayer-python/issues

Environment Information

Operating System: Mac OS X 10.12.3
softlayer-python version (slcli --version): slcli (SoftLayer Command-line), version 5.2.0

@camporter
Copy link
Member

I've made a PR to fix the issue of the unexpected error when billing is not available for a firewall.

@allmightyspiff
Copy link
Member

I've merged the changes into the master branch, and this fix will be in the 5.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants