Skip to content

Commit 6d34bb1

Browse files
committed
test: rename config field
1 parent ad211b4 commit 6d34bb1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

conn_test.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func init() {
3333
panic("Can not setup connections to Google Cloud... Check credentials, and connection string")
3434
}
3535

36-
ds := testConn.client.Dataset(testConfig.DataSet)
36+
ds := testConn.client.Dataset(testConfig.DatasetID)
3737
_, err = ds.Metadata(ctx)
3838
if err != nil {
3939
panic("Can not get dataset, check your connection string, permissions, and that it exists in your project")
@@ -86,7 +86,7 @@ func setupConnections() (err error) {
8686
}
8787
testClient, err = bigquery.NewClient(ctx, testConfig.ProjectID)
8888
testConn.projectID = testConfig.ProjectID
89-
testConn.ds = testClient.Dataset(testConfig.DataSet)
89+
testConn.ds = testClient.Dataset(testConfig.DatasetID)
9090
testMockDataset = &mockDataset{}
9191
return
9292
}
@@ -123,7 +123,7 @@ func TestConfigFromConnString(t *testing.T) {
123123

124124
wantCfg: &Config{
125125
Location: "us",
126-
DataSet: "dataset1",
126+
DatasetID: "dataset1",
127127
ProjectID: "projectid",
128128
},
129129
wantErr: false,
@@ -292,7 +292,7 @@ func TestConnector_Connect(t *testing.T) {
292292
client: testClient,
293293
ds: &bigquery.Dataset{
294294
ProjectID: testConfig.ProjectID,
295-
DatasetID: testConfig.DataSet,
295+
DatasetID: testConfig.DatasetID,
296296
},
297297
projectID: testConfig.ProjectID,
298298
bad: false,
@@ -544,7 +544,7 @@ func TestConn_Ping(t *testing.T) {
544544
Location: "us",
545545
},
546546
ds: testMockDataset,
547-
projectID: testConfig.DataSet,
547+
projectID: testConfig.ProjectID,
548548
},
549549
args: args{
550550
ctx: context.TODO(),
@@ -684,7 +684,7 @@ type mockDataset struct {
684684

685685
func (m *mockDataset) Metadata(ctx context.Context) (md *bigquery.DatasetMetadata, err error) {
686686
return &bigquery.DatasetMetadata{
687-
Name: m.config.DataSet,
687+
Name: m.config.DatasetID,
688688
Location: m.config.Location,
689689
}, nil
690690
}

driver_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func TestDriver_Open(t *testing.T) {
3939
wantC: &Conn{
4040
cfg: &Config{
4141
Location: "us",
42-
DataSet: "dataset1",
42+
DatasetID: "dataset1",
4343
ProjectID: "projectid",
4444
},
4545
},

0 commit comments

Comments
 (0)