Skip to content

Question about antlr4 dependency & minimum Node version #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cgewecke opened this issue Dec 3, 2020 · 3 comments · Fixed by #34
Closed

Question about antlr4 dependency & minimum Node version #33

cgewecke opened this issue Dec 3, 2020 · 3 comments · Fixed by #34

Comments

@cgewecke
Copy link

cgewecke commented Dec 3, 2020 •
edited
Loading

(Thanks a million for maintaining this @fvictorio. It's the best.)

In 71f83ca antlr4 is added as a direct dependency.

Was updating some things to 0.9.1 and am getting the installation error below when is Node < 14.

14 is LTS as of late October but just wanted to double-check with you that this is expected.

[2/4] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14". Got "12.16.0"
error Found incompatible module.
@cgewecke
Copy link
Author

cgewecke commented Dec 3, 2020

Sorry, I just found the relevant antlr4 docs and they say that's their target. 😅

@cgewecke cgewecke closed this as completed Dec 3, 2020
@fvictorio fvictorio reopened this Dec 3, 2020
@fvictorio
Copy link
Contributor

fvictorio commented Dec 3, 2020 •
edited
Loading

But you are right, this shouldn't happen. I'm planning on packaging this library with rollup or something like that, and to remove antlr4 as a dependency. That way this library will continue to work with any version.

@fvictorio fvictorio mentioned this issue Dec 6, 2020
Merged
@fvictorio
Copy link
Contributor

Fixed on @solidity-parser/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundle all the project solidity-parser/parser
2 participants
@fvictorio @cgewecke