Skip to content

Commit 60aa991

Browse files
committed
Build - qt5 is no longer supported
1 parent 92113ae commit 60aa991

File tree

1 file changed

+23
-47
lines changed

1 file changed

+23
-47
lines changed

app/gui/CMakeLists.txt

+23-47
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.2)
1+
cmake_minimum_required(VERSION 3.13)
22

33
message(STATUS "CMakeLists: Sonic Pi Qt GUI")
44

@@ -28,10 +28,10 @@ if((${BUILD_32BIT}) AND (DEFINED ENV{QT_INSTALL_LOCATION32}))
2828
elseif(DEFINED ENV{QT_INSTALL_LOCATION})
2929
message(STATUS "Setting prefix to user-defined Qt install location: $ENV{QT_INSTALL_LOCATION}")
3030
set(CMAKE_PREFIX_PATH $ENV{QT_INSTALL_LOCATION})
31-
elseif(APPLE AND EXISTS /usr/local/opt/qt@5)
32-
# Homebrew installs Qt into/usr/local/qt5
33-
message(STATUS "Setting prefix to Homebrew's Qt install location: /usr/local/opt/qt@5")
34-
set(CMAKE_PREFIX_PATH /usr/local/opt/qt@5)
31+
elseif(APPLE AND EXISTS /opt/homebrew/opt/qt@6)
32+
# Homebrew installs Qt to /opt/homebrew/opt/qt@6
33+
message(STATUS "Setting prefix to Homebrew's Qt install location: /opt/homebrew/opt/qt@6")
34+
set(CMAKE_PREFIX_PATH /opt/homebrew/opt/qt@6)
3535
endif()
3636

3737
# Qt Setup
@@ -44,18 +44,13 @@ set(QT_TOOLS_DIR ${CMAKE_PREFIX_PATH}/bin)
4444
set_property(GLOBAL PROPERTY AUTOMOC_FOLDER Automoc)
4545
set_property(GLOBAL PROPERTY AUTOGEN_TARGETS_FOLDER Automoc)
4646

47-
find_package(Qt6 QUIET)
47+
find_package(Qt6)
4848

4949
if(Qt6_FOUND AND WITH_QT_GUI_WEBENGINE)
5050
find_package(Qt6 COMPONENTS Core Widgets Gui Concurrent Network OpenGLWidgets PrintSupport Xml Svg LinguistTools WebEngineWidgets REQUIRED)
5151
add_compile_definitions(WITH_WEBENGINE)
5252
elseif(Qt6_FOUND)
5353
find_package(Qt6 COMPONENTS Core Widgets Gui Concurrent Network OpenGLWidgets PrintSupport Xml Svg LinguistTools REQUIRED)
54-
elseif(WITH_QT_GUI_WEBENGINE)
55-
find_package(Qt5 COMPONENTS Core Widgets Gui Concurrent Network OpenGL PrintSupport Xml Svg LinguistTools WebEngineWidgets REQUIRED)
56-
add_compile_definitions(WITH_WEBENGINE)
57-
else()
58-
find_package(Qt5 COMPONENTS Core Widgets Gui Concurrent Network OpenGL PrintSupport Xml Svg LinguistTools REQUIRED)
5954
endif()
6055

6156
find_package(Threads REQUIRED)
@@ -221,20 +216,17 @@ endif()
221216
set_source_files_properties(${TS_FILES} PROPERTIES OUTPUT_LOCATION ${QTAPP_ROOT}/lang)
222217

223218

224-
if (Qt6_FOUND)
225-
if (${Qt6Core_VERSION} VERSION_LESS "6.7.0")
226-
qt_add_lrelease(${APP_NAME} TS_FILES ${TS_FILES})
227-
else()
228-
# Qt 6.7.0 and later...
229-
set(LRELEASE_TARGET "${APP_NAME}_lrelease")
230-
qt_add_lrelease(TS_FILES ${TS_FILES} LRELEASE_TARGET ${LRELEASE_TARGET})
231-
endif()
219+
220+
if (${Qt6Core_VERSION} VERSION_LESS "6.7.0")
221+
qt_add_lrelease(${APP_NAME} TS_FILES ${TS_FILES})
232222
else()
233-
qt5_add_translation(QM_FILES ${TS_FILES})
234-
set_property(SOURCE ${APP_NAME} APPEND PROPERTY OBJECT_DEPENDS ${QM_FILES})
223+
# Qt 6.7.0 and later...
224+
set(LRELEASE_TARGET "${APP_NAME}_lrelease")
225+
qt_add_lrelease(TS_FILES ${TS_FILES} LRELEASE_TARGET ${LRELEASE_TARGET})
235226
endif()
236227

237228

229+
238230
if (APPLE)
239231
set_target_properties(
240232
${APP_NAME} PROPERTIES
@@ -319,37 +311,21 @@ target_link_libraries(${APP_NAME}
319311
Threads::Threads
320312
SingleApplication::SingleApplication)
321313

322-
if(Qt5_FOUND)
323-
target_link_libraries(${APP_NAME}
324-
PRIVATE
325-
Qt5::Core
326-
Qt5::Gui
327-
Qt5::Widgets
328-
Qt5::OpenGL
329-
Qt5::Concurrent
330-
Qt5::Network)
331-
else()
332-
target_link_libraries(${APP_NAME}
333-
PRIVATE
334-
Qt::Core
335-
Qt::Gui
336-
Qt::Widgets
337-
Qt::OpenGL
338-
Qt::Concurrent
339-
Qt::Network
340-
Qt::OpenGLWidgets)
341-
endif()
314+
target_link_libraries(${APP_NAME}
315+
PRIVATE
316+
Qt::Core
317+
Qt::Gui
318+
Qt::Widgets
319+
Qt::OpenGL
320+
Qt::Concurrent
321+
Qt::Network
322+
Qt::OpenGLWidgets)
323+
342324

343325
if(WITH_QT_GUI_WEBENGINE)
344-
if(Qt5_FOUND)
345-
target_link_libraries(${APP_NAME}
346-
PRIVATE
347-
Qt5::WebEngineWidgets)
348-
else()
349326
target_link_libraries(${APP_NAME}
350327
PRIVATE
351328
Qt::WebEngineWidgets)
352-
endif()
353329
endif()
354330

355331

0 commit comments

Comments
 (0)