remove extension API status bar (#45921)

This was not used in any important way by any legacy extensions and is not used by the new code intel support. Removing this is part of our removal of the legacy extension API.

Author: sqs

client/extension-api/src/sourcegraph.d.ts

@@ -629,32 +629,6 @@ declare module 'sourcegraph' {
         readonly key: string
     }
 
-    /**
-     * A text element displayed in an editor's status bar.
-     * A status bar item can display tooltips on hover and execute commands on click
-     */
-    export interface StatusBarItem {
-        /** The text to display in the status bar */
-        text: string
-
-        /** Tooltip text to display when hovering over the status bar item. */
-        tooltip?: string
-
-        /** The id of and arguments to a command to execute when the status bar item is clicked */
-        command?: { id: string; args?: any[] }
-    }
-
-    /**
-     * Represents a handle to a status bar item.
-     *
-     * To get an instance of {@link StatusBarItemType}, use
-     * {@link sourcegraph.app.createStatusBarItemType}
-     */
-    export interface StatusBarItemType {
-        /** An opaque identifier. */
-        readonly key: string
-    }
-
     export interface Directory {
         /**
          * The URI of the directory.
@@ -724,16 +698,6 @@ declare module 'sourcegraph' {
          *
          */
         setDecorations(decorationType: TextDocumentDecorationType, decorations: TextDocumentDecoration[]): void
-
-        /**
-         * Add a status bar item to this editor's status bar. If a status bar item already exists with the given
-         * {@link StatusBarItemType}, it will be replaced.
-         *
-         * @see {@link StatusBarItemType}
-         * @see {@link sourcegraph.app.createStatusBarItemType}
-         *
-         */
-        setStatusBarItem(statusBarItemType: StatusBarItemType, statusBarItem: StatusBarItem): void
     }
 
     /**
@@ -1145,15 +1109,6 @@ declare module 'sourcegraph' {
          */
         export function createDecorationType(): TextDocumentDecorationType
 
-        /**
-         * Creates a statusBarItemType that can be used to add a status bar item to
-         * the status bar of code views.
-         *
-         * Use this to create a unique handle to a status bar item, that can be applied to
-         * text editors using {@link setStatusBarItem}.
-         */
-        export function createStatusBarItemType(): StatusBarItemType
-
         /**
          * Register a view provider, which provides the contents of a view.
          *

client/shared/src/api/contract.ts

@@ -12,7 +12,6 @@ import { SettingsCascade } from '../settings/settings'
 
 import { SettingsEdit } from './client/services/settings'
 import { ExecutableExtension } from './extension/activation'
-import { StatusBarItemWithKey } from './extension/api/codeEditor'
 import { ProxySubscribable } from './extension/api/common'
 import {
     FileDecorationsByPath,
@@ -168,7 +167,6 @@ export interface FlatExtensionHostAPI {
     ) => ProxySubscribable<ViewProviderResult[]>
 
     getGlobalPageViews: (context: ViewContexts['global/page']) => ProxySubscribable<ViewProviderResult[]>
-    getStatusBarItems: (viewerId: ViewerId) => ProxySubscribable<StatusBarItemWithKey[]>
 
     // Content
     getLinkPreviews: (url: string) => ProxySubscribable<LinkPreviewMerged | null>

client/shared/src/api/extension/api/codeEditor.ts

@@ -1,5 +1,5 @@
 import { ProxyMarked, proxyMarker } from 'comlink'
-import { isEqual, uniqueId } from 'lodash'
+import { isEqual } from 'lodash'
 import { BehaviorSubject, Observable } from 'rxjs'
 import * as sourcegraph from 'sourcegraph'
 
@@ -11,10 +11,6 @@ import { CodeEditorData, ViewerId } from '../../viewerTypes'
 import { createDecorationType } from './decorations'
 import { ExtensionDocument } from './textDocument'
 
-export const createStatusBarItemType = (): sourcegraph.StatusBarItemType => ({ key: uniqueId('StatusBarItemType') })
-
-export type StatusBarItemWithKey = sourcegraph.StatusBarItem & sourcegraph.StatusBarItemType
-
 const DEFAULT_DECORATION_TYPE = createDecorationType()
 
 /** @internal */
@@ -70,23 +66,6 @@ export class ExtensionCodeEditor implements sourcegraph.CodeEditor, ProxyMarked
         )
     }
 
-    private _statusBarItemsByType = new Map<sourcegraph.StatusBarItemType, StatusBarItemWithKey>()
-
-    private _mergedStatusBarItems = new BehaviorSubject<StatusBarItemWithKey[]>([])
-    public get mergedStatusBarItems(): Observable<StatusBarItemWithKey[]> {
-        return this._mergedStatusBarItems
-    }
-
-    public setStatusBarItem(
-        statusBarItemType: sourcegraph.StatusBarItemType,
-        statusBarItem: sourcegraph.StatusBarItem
-    ): void {
-        this._statusBarItemsByType.set(statusBarItemType, { ...statusBarItem, ...statusBarItemType })
-        this._mergedStatusBarItems.next(
-            [...this._statusBarItemsByType.values()].flat().filter(statusBarItem => isValidStatusBarItem(statusBarItem))
-        )
-    }
-
     public update(data: Pick<CodeEditorData, 'selections'>): void {
         const newSelections = data.selections.map(selection => Selection.fromPlain(selection))
 
@@ -113,8 +92,6 @@ const isEmptyObjectDeep = (value: any): boolean =>
 const isDecorationEmpty = ({ range, isWholeLine, ...contents }: clientType.TextDocumentDecoration): boolean =>
     isEmptyObjectDeep(contents)
 
-const isValidStatusBarItem = ({ key, text }: StatusBarItemWithKey): boolean => !!key && !!text
-
 function fromTextDocumentDecoration(decoration: sourcegraph.TextDocumentDecoration): clientType.TextDocumentDecoration {
     return {
         ...decoration,

client/shared/src/api/extension/extensionApi.ts

@@ -10,7 +10,6 @@ import { Location, MarkupKind, Position, Range, Selection } from '@sourcegraph/e
 import { ClientAPI } from '../client/api/api'
 import { syncRemoteSubscription } from '../util'
 
-import { createStatusBarItemType } from './api/codeEditor'
 import { proxySubscribable } from './api/common'
 import { createDecorationType } from './api/decorations'
 import { DocumentHighlightKind } from './api/documentHighlights'
@@ -240,7 +239,6 @@ export function createExtensionAPIFactory(
             }
         },
         createDecorationType,
-        createStatusBarItemType,
         // `log` is implemented on extension activation
         log: noop,
     }

client/shared/src/api/extension/extensionHostApi.ts

@@ -489,24 +489,6 @@ export function createExtensionHostAPI(state: ExtensionHostState): FlatExtension
 
         getGlobalPageViews: context => proxySubscribable(callViewProviders(context, state.globalPageViewProviders)),
 
-        getStatusBarItems: ({ viewerId }) => {
-            const viewer = getViewer(viewerId)
-            if (viewer.type !== 'CodeEditor') {
-                return proxySubscribable(EMPTY)
-            }
-
-            return proxySubscribable(
-                viewer.mergedStatusBarItems.pipe(
-                    debounceTime(0),
-                    map(statusBarItems =>
-                        statusBarItems.sort(
-                            (a, b) => a.text[0].toLowerCase().charCodeAt(0) - b.text[0].toLowerCase().charCodeAt(0)
-                        )
-                    )
-                )
-            )
-        },
-
         // Content
         getLinkPreviews: (url: string) =>
             proxySubscribable(

client/shared/src/codeintel/legacy-extensions/api.ts

@@ -216,32 +216,6 @@ export interface TextDocumentDecorationType {
     readonly key: string
 }
 
-/**
- * A text element displayed in an editor's status bar.
- * A status bar item can display tooltips on hover and execute commands on click
- */
-export interface StatusBarItem {
-    /** The text to display in the status bar */
-    text: string
-
-    /** Tooltip text to display when hovering over the status bar item. */
-    tooltip?: string
-
-    /** The id of and arguments to a command to execute when the status bar item is clicked */
-    command?: { id: string; args?: any[] }
-}
-
-/**
- * Represents a handle to a status bar item.
- *
- * To get an instance of {@link StatusBarItemType}, use
- * {@link sourcegraph.app.createStatusBarItemType}
- */
-export interface StatusBarItemType {
-    /** An opaque identifier. */
-    readonly key: string
-}
-
 export interface Directory {
     /**
      * The URI of the directory.

client/web/src/codeintel/ReferencesPanel.tsx

@@ -743,7 +743,6 @@ const SideBlob: React.FunctionComponent<React.PropsWithChildren<SideBlobProps>>
             nav={props.blobNav}
             history={history}
             location={location}
-            disableStatusBar={true}
             disableDecorations={true}
             wrapCode={true}
             className={styles.sideBlobCode}

client/web/src/components/diff/FileDiffHunks.module.scss

@@ -2,11 +2,6 @@
     margin-bottom: 1rem;
 }
 
-.status-bar {
-    background-color: var(--code-bg);
-    height: 2rem;
-}
-
 .body {
     border: 1px solid var(--border-color);
     border-radius: var(--border-radius);

client/web/src/components/diff/FileDiffHunks.tsx

@@ -3,7 +3,7 @@ import React, { useCallback, useMemo, useState, useEffect } from 'react'
 import classNames from 'classnames'
 import * as H from 'history'
 import { combineLatest, from, NEVER, Observable, of, ReplaySubject, Subscription } from 'rxjs'
-import { distinctUntilKeyChanged, filter, first, map, switchMap, tap } from 'rxjs/operators'
+import { filter, first, map, switchMap, tap } from 'rxjs/operators'
 import { useDeepCompareEffectNoCheck } from 'use-deep-compare-effect'
 
 import { findPositionsFromEvents } from '@sourcegraph/codeintellify'
@@ -15,7 +15,6 @@ import { ThemeProps } from '@sourcegraph/shared/src/theme'
 import { toURIWithPath } from '@sourcegraph/shared/src/util/url'
 import { useObservable } from '@sourcegraph/wildcard'
 
-import { StatusBar } from '../../extensions/components/StatusBar'
 import { FileDiffFields } from '../../graphql-operations'
 import { DiffMode } from '../../repo/commit/RepositoryCommitPage'
 import { diffDomFunctions } from '../../repo/compare/dom-functions'
@@ -53,7 +52,6 @@ export interface FileHunksProps extends ThemeProps {
     lineNumbers: boolean
 
     className: string
-    location: H.Location
     history: H.History
     /** Reflect selected line in url */
     persistLines?: boolean
@@ -67,7 +65,6 @@ export const FileDiffHunks: React.FunctionComponent<React.PropsWithChildren<File
     hunks,
     isLightTheme,
     lineNumbers,
-    location,
     extensionInfo,
     persistLines,
     diffMode,
@@ -140,30 +137,6 @@ export const FileDiffHunks: React.FunctionComponent<React.PropsWithChildren<File
         [extensionInfoChanges]
     )
 
-    const getHeadStatusBarItems = useCallback(
-        () =>
-            baseAndHeadViewerIds.pipe(
-                distinctUntilKeyChanged('headViewerId'),
-                switchMap(({ headViewerId, extensionHostAPI }) =>
-                    headViewerId ? wrapRemoteObservable(extensionHostAPI.getStatusBarItems(headViewerId)) : of(null)
-                ),
-                map(statusBarItems => statusBarItems || [])
-            ),
-        [baseAndHeadViewerIds]
-    )
-
-    const getBaseStatusBarItems = useCallback(
-        () =>
-            baseAndHeadViewerIds.pipe(
-                distinctUntilKeyChanged('baseViewerId'),
-                switchMap(({ baseViewerId, extensionHostAPI }) =>
-                    baseViewerId ? wrapRemoteObservable(extensionHostAPI.getStatusBarItems(baseViewerId)) : of(null)
-                ),
-                map(statusBarItems => statusBarItems || [])
-            ),
-        [baseAndHeadViewerIds]
-    )
-
     // Listen for line decorations from extensions
     useObservable(
         useMemo(
@@ -227,41 +200,6 @@ export const FileDiffHunks: React.FunctionComponent<React.PropsWithChildren<File
 
     return (
         <div className={styles.body}>
-            {extensionInfo && (
-                <div className={classNames('w-100', isSplitMode && 'd-flex ')}>
-                    {/* Always render base status bar even though it isn't displayed in unified mode
-                    in order to prevent overloading the extension host with messages (`api.getStatusBarItems`) on
-                    mode switch, which noticeably decreases status bar performance. */}
-                    {extensionInfo.extensionsController !== null && window.context.enableLegacyExtensions ? (
-                        <>
-                            <StatusBar
-                                getStatusBarItems={getBaseStatusBarItems}
-                                className={classNames(
-                                    isSplitMode && 'flex-1 w-50',
-                                    'border-bottom border-top-0',
-                                    styles.statusBar
-                                )}
-                                statusBarItemClassName="mx-0"
-                                extensionsController={extensionInfo.extensionsController}
-                                location={location}
-                                badgeText="BASE"
-                            />
-                            <StatusBar
-                                getStatusBarItems={getHeadStatusBarItems}
-                                className={classNames(
-                                    isSplitMode && 'w-50',
-                                    'flex-1 border-bottom border-top-0',
-                                    styles.statusBar
-                                )}
-                                statusBarItemClassName="mx-0"
-                                extensionsController={extensionInfo.extensionsController}
-                                location={location}
-                                badgeText="HEAD"
-                            />
-                        </>
-                    ) : null}
-                </div>
-            )}
             <div className={classNames(styles.fileDiffHunks, className)} ref={nextBlobElement}>
                 {hunks.length === 0 ? (
                     <div className="text-muted m-2">No changes</div>

client/web/src/components/diff/FileDiffNode.tsx

@@ -160,7 +160,6 @@ export const FileDiffNode: React.FunctionComponent<React.PropsWithChildren<FileD
                             fileDiffAnchor={anchor}
                             history={history}
                             isLightTheme={isLightTheme}
-                            location={location}
                             persistLines={persistLines}
                             extensionInfo={
                                 extensionInfo && {

client/web/src/enterprise/batches/BatchSpecNode.module.scss

@@ -188,9 +188,7 @@
     }
 
     :global(.bottom-spacer) {
-        // Give room to view the last few lines of code
-        // without the floating status bar getting in the way.
-        height: calc(var(--blob-status-bar-height) + var(--blob-status-bar-vertical-gap) + 1.5rem);
+        height: 1.5rem;
     }
 
     &--wrapped {