Warn when attempting to resolve a schema without identifiers (#311)

Signed-off-by: Juan Cruz Viotti <[email protected]>

Author: jviotti

DEPENDENCIES

@@ -1,5 +1,5 @@
 vendorpull https://github.com/sourcemeta/vendorpull dea311b5bfb53b6926a4140267959ae334d3ecf4
-core https://github.com/sourcemeta/core dfc6083428219aa07f5b05da377ddd910d0518b0
+core https://github.com/sourcemeta/core ca03804875d4f7485fcf9ac04846cf382136b919
 hydra https://github.com/sourcemeta/hydra a67b879df800e834ed8a2d056f98398f7211d870
 jsonbinpack https://github.com/sourcemeta/jsonbinpack 7028964423b96755c4ea6869aa7bc439650ceecd
 blaze https://github.com/sourcemeta/blaze b35d9b34806ae6dcc7b58c1d4b943b0877f8afa7

src/utils.cc

@@ -328,7 +328,13 @@ auto resolver(const std::map<std::string, std::vector<std::string>> &options,
                        parse_extensions(options))) {
       log_verbose(options) << "Importing schema into the resolution context: "
                            << entry.first.string() << "\n";
-      dynamic_resolver.add(entry.second, default_dialect);
+      const auto result = dynamic_resolver.add(entry.second, default_dialect);
+      if (!result) {
+        std::cerr
+            << "warning: No schema resources were imported from this file\n";
+        std::cerr << "  at " << entry.first.string() << "\n";
+        std::cerr << "Are you sure this schema sets any identifiers?\n";
+      }
     }
   }
 
@@ -338,7 +344,13 @@ auto resolver(const std::map<std::string, std::vector<std::string>> &options,
                        parse_extensions(options))) {
       log_verbose(options) << "Importing schema into the resolution context: "
                            << entry.first.string() << "\n";
-      dynamic_resolver.add(entry.second, default_dialect);
+      const auto result = dynamic_resolver.add(entry.second, default_dialect);
+      if (!result) {
+        std::cerr
+            << "warning: No schema resources were imported from this file\n";
+        std::cerr << "  at " << entry.first.string() << "\n";
+        std::cerr << "Are you sure this schema sets any identifiers?\n";
+      }
     }
   }
 

test/CMakeLists.txt

@@ -55,6 +55,7 @@ add_jsonschema_test_unix(validate/pass_trace)
 add_jsonschema_test_unix(validate/pass_trace_fast)
 add_jsonschema_test_unix(validate/pass_resolve)
 add_jsonschema_test_unix(validate/pass_resolve_custom_extension)
+add_jsonschema_test_unix(validate/pass_resolve_without_identifier)
 add_jsonschema_test_unix(validate/pass_resolve_verbose)
 add_jsonschema_test_unix(validate/pass_verbose)
 add_jsonschema_test_unix(validate/pass_draft4)

test/validate/pass_resolve_without_identifier.sh

@@ -0,0 +1,37 @@
+#!/bin/sh
+
+set -o errexit
+set -o nounset
+
+TMP="$(mktemp -d)"
+clean() { rm -rf "$TMP"; }
+trap clean EXIT
+
+cat << 'EOF' > "$TMP/schema.json"
+{
+  "$schema": "http://json-schema.org/draft-04/schema#",
+  "type": "string"
+}
+EOF
+
+cat << 'EOF' > "$TMP/instance.json"
+"foo"
+EOF
+
+cat << 'EOF' > "$TMP/no-id.json"
+{
+  "$schema": "http://json-schema.org/draft-04/schema#",
+  "type": "boolean"
+}
+EOF
+
+"$1" validate "$TMP/schema.json" "$TMP/instance.json" \
+  --resolve "$TMP/no-id.json" 2>"$TMP/stderr.txt"
+
+cat << EOF > "$TMP/expected.txt"
+warning: No schema resources were imported from this file
+  at $(realpath "$TMP")/no-id.json
+Are you sure this schema sets any identifiers?
+EOF
+
+diff "$TMP/stderr.txt" "$TMP/expected.txt"