fix(metadata): do not override name fixes api-platform#5235

Author: soyuka

src/Metadata/Resource/Factory/OperationDefaultsTrait.php

@@ -187,17 +187,6 @@ private function getOperationWithDefaults(ApiResource $resource, Operation $oper
             $operation = $operation->withName($operation->getRouteName());
         }
 
-        // Check for name conflict
-        if ($operation->getName() && null !== ($operations = $resource->getOperations())) {
-            if (!$operations->has($operation->getName())) {
-                return [$operation->getName(), $operation];
-            }
-
-            $this->logger->warning(sprintf('The operation "%s" already exists on the resource "%s", pick a different name or leave it empty. In the meantime we will generate a unique name.', $operation->getName(), $resource->getClass()));
-            /** @var HttpOperation $operation */
-            $operation = $operation->withName('');
-        }
-
         $operationName = $operation->getName() ?? sprintf(
             '_api_%s_%s%s',
             $operation->getUriTemplate() ?: $operation->getShortName(),

tests/Fixtures/TestBundle/ApiResource/PasswordResource.php

@@ -0,0 +1,37 @@
+<?php declare(strict_types = 1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use ApiPlatform\Metadata\Post;
+
+#[
+    ApiResource(
+        shortName: 'User',
+        operations: [
+            new Post(
+                uriTemplate: '/password/reset',
+                name: 'password_reset',
+            ),
+            new Post(
+                uriTemplate: '/password/set',
+                name: 'password_set',
+            ),
+            new Get(
+                uriTemplate: '/password/reset/{token}',
+                name: 'password_reset_token',
+            ),
+        ],
+        routePrefix: '/users'
+    )
+]
+/**
+ * Test for issue #5235
+ */
+class PasswordResource
+{
+    #[ApiProperty(identifier: true)]
+    public ?string $token = null;
+}

tests/Metadata/Resource/Factory/AttributesResourceMetadataCollectionFactoryTest.php

@@ -27,6 +27,7 @@
 use ApiPlatform\Metadata\Put;
 use ApiPlatform\Metadata\Resource\Factory\AttributesResourceMetadataCollectionFactory;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
+use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\PasswordResource;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\AttributeDefaultOperations;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\AttributeOnlyOperation;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\AttributeResource;
@@ -226,4 +227,19 @@ class: AttributeOnlyOperation::class,
             ),
         ]), $attributeResourceMetadataCollectionFactory->create(AttributeOnlyOperation::class));
     }
+
+    /**
+     * Tests issue #5235
+     */
+    public function testNameDeclarationShouldNotBeRemoved(): void
+    {
+        $attributeResourceMetadataCollectionFactory = new AttributesResourceMetadataCollectionFactory();
+
+        $operation = new HttpOperation(shortName: 'AttributeOnlyOperation', class: AttributeOnlyOperation::class);
+        $metadataCollection = $attributeResourceMetadataCollectionFactory->create(PasswordResource::class);
+        $operations = $metadataCollection[0]->getOperations();
+        $this->assertTrue($operations->has('password_set'));
+        $this->assertTrue($operations->has('password_reset_token'));
+        $this->assertTrue($operations->has('password_reset'));
+    }
 }