From 89ceeb69ec4b19b9260e3f589279d196ab448dcc Mon Sep 17 00:00:00 2001 From: Nathan Seidle Date: Fri, 13 Nov 2020 13:12:21 -0700 Subject: [PATCH 1/2] Remove const variable to avoid -Wvla warnings --- core-implement/HardwareSerial.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-implement/HardwareSerial.cpp b/core-implement/HardwareSerial.cpp index 67b2e33..0f7d724 100644 --- a/core-implement/HardwareSerial.cpp +++ b/core-implement/HardwareSerial.cpp @@ -149,7 +149,7 @@ int UART::printf(const char *format, ...){ va_list args; va_start(args, format); - const int space = vsnprintf(NULL, 0, format, args) + 1; + int space = vsnprintf(NULL, 0, format, args) + 1; char buf[space]; memset(buf, 0x00, space); vsnprintf(buf, space, format, args); From 471cc5124a6f4efe591ec7adc6301991d46dfa10 Mon Sep 17 00:00:00 2001 From: Nathan Seidle Date: Fri, 13 Nov 2020 13:32:27 -0700 Subject: [PATCH 2/2] Use alloc() to avoid warning --- core-implement/HardwareSerial.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core-implement/HardwareSerial.cpp b/core-implement/HardwareSerial.cpp index 0f7d724..ff1327f 100644 --- a/core-implement/HardwareSerial.cpp +++ b/core-implement/HardwareSerial.cpp @@ -149,8 +149,9 @@ int UART::printf(const char *format, ...){ va_list args; va_start(args, format); - int space = vsnprintf(NULL, 0, format, args) + 1; - char buf[space]; + const int space = vsnprintf(NULL, 0, format, args) + 1; + char *buf; + buf = (char *) alloca(space); memset(buf, 0x00, space); vsnprintf(buf, space, format, args); va_end(args);