fix: failing test for undecodable payload

jryd · jryd · commit 85ebd0b39ef2 · 2024-04-02T16:13:45.000+10:00
diff --git a/src/Recorders/JobRecorder/JobRecorder.php b/src/Recorders/JobRecorder/JobRecorder.php
@@ -75,11 +75,11 @@ protected function getJobProperties(): array
             }
         }
 
-        if (is_string($payload['data'])) {
-            try {
+        try {
+            if (is_string($payload['data'])) {
                 $properties['data'] = json_decode($payload['data'], true, 512, JSON_THROW_ON_ERROR);
-            } catch (Exception $exception) {
             }
+        } catch (Exception $exception) {
         }
 
         if ($pushedAt = DateTime::createFromFormat('U.u', $payload->get('pushedAt', ''))) {

Original file line number	Diff line number	Diff line change
`@@ -75,11 +75,11 @@ protected function getJobProperties(): array`
`75`	`75`	`}`
`76`	`76`	`}`
`77`	`77`
`78`		`- if (is_string($payload['data'])) {`
`79`		`- try {`
	`78`	`+ try {`
	`79`	`+ if (is_string($payload['data'])) {`
`80`	`80`	`$properties['data'] = json_decode($payload['data'], true, 512, JSON_THROW_ON_ERROR);`
`81`		`- } catch (Exception $exception) {`
`82`	`81`	`}`
	`82`	`+ } catch (Exception $exception) {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`if ($pushedAt = DateTime::createFromFormat('U.u', $payload->get('pushedAt', ''))) {`