log: avoid setting default slog logger in init (ethereum#28747)

fjl · Dergarcon · commit fc684ad6a3dc · 2024-01-30T19:39:40.000-06:00
slog.SetDefault has undesirable side effects. It also sets the default logger destination,
for example. So we should not call it by default in init.
diff --git a/log/root.go b/log/root.go
@@ -10,8 +10,7 @@ import (
 var root atomic.Value
 
 func init() {
-	defaultLogger := &logger{slog.New(DiscardHandler())}
-	SetDefault(defaultLogger)
+	root.Store(&logger{slog.New(DiscardHandler())})
 }
 
 // SetDefault sets the default global logger

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,7 @@ import (`
`10`	`10`	`var root atomic.Value`
`11`	`11`
`12`	`12`	`func init() {`
`13`		`- defaultLogger := &logger{slog.New(DiscardHandler())}`
`14`		`- SetDefault(defaultLogger)`
	`13`	`+ root.Store(&logger{slog.New(DiscardHandler())})`
`15`	`14`	`}`
`16`	`15`
`17`	`16`	`// SetDefault sets the default global logger`