fix unit test

Author: abhinavnagaraj

controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook_test.go

@@ -467,8 +467,8 @@ func TestKubeadmControlPlaneValidateUpdate(t *testing.T) {
 			kcp:       validUpdate,
 		},
 		{
-			name:      "should return error when trying to mutate the kubeadmconfigspec initconfiguration",
-			expectErr: true,
+			name:      "should not return error when trying to mutate the kubeadmconfigspec initconfiguration",
+			expectErr: false,
 			before:    before,
 			kcp:       invalidUpdateKubeadmConfigInit,
 		},
@@ -479,14 +479,14 @@ func TestKubeadmControlPlaneValidateUpdate(t *testing.T) {
 			kcp:       validUpdateKubeadmConfigInit,
 		},
 		{
-			name:      "should return error when trying to mutate the kubeadmconfigspec clusterconfiguration",
-			expectErr: true,
+			name:      "should not return error when trying to mutate the kubeadmconfigspec clusterconfiguration",
+			expectErr: false,
 			before:    before,
 			kcp:       invalidUpdateKubeadmConfigCluster,
 		},
 		{
-			name:      "should return error when trying to mutate the kubeadmconfigspec joinconfiguration",
-			expectErr: true,
+			name:      "should not return error when trying to mutate the kubeadmconfigspec joinconfiguration",
+			expectErr: false,
 			before:    before,
 			kcp:       invalidUpdateKubeadmConfigJoin,
 		},
@@ -545,38 +545,38 @@ func TestKubeadmControlPlaneValidateUpdate(t *testing.T) {
 			kcp:       etcdLocalImageInvalidTag,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's networking struct",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's networking struct",
+			expectErr: false,
 			before:    before,
 			kcp:       networking,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's kubernetes version",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's kubernetes version",
+			expectErr: false,
 			before:    before,
 			kcp:       kubernetesVersion,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's controlPlaneEndpoint",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's controlPlaneEndpoint",
+			expectErr: false,
 			before:    before,
 			kcp:       controlPlaneEndpoint,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's apiServer",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's apiServer",
+			expectErr: false,
 			before:    before,
 			kcp:       apiServer,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's controllerManager",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's controllerManager",
+			expectErr: false,
 			before:    before,
 			kcp:       controllerManager,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's scheduler",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's scheduler",
+			expectErr: false,
 			before:    before,
 			kcp:       scheduler,
 		},
@@ -617,8 +617,8 @@ func TestKubeadmControlPlaneValidateUpdate(t *testing.T) {
 			kcp:       dnsInvalidCoreDNSToVersion,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's certificatesDir",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's certificatesDir",
+			expectErr: false,
 			before:    before,
 			kcp:       certificatesDir,
 		},
@@ -629,56 +629,56 @@ func TestKubeadmControlPlaneValidateUpdate(t *testing.T) {
 			kcp:       imageRepository,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's useHyperKubeImage field",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's useHyperKubeImage field",
+			expectErr: false,
 			before:    before,
 			kcp:       useHyperKubeImage,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's featureGates",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's featureGates",
+			expectErr: false,
 			before:    before,
 			kcp:       featureGates,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's local etcd's configuration localDataDir field",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's local etcd's configuration localDataDir field",
+			expectErr: false,
 			before:    before,
 			kcp:       localDataDir,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's local etcd's configuration localPeerCertSANs field",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's local etcd's configuration localPeerCertSANs field",
+			expectErr: false,
 			before:    before,
 			kcp:       localPeerCertSANs,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's local etcd's configuration localServerCertSANs field",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's local etcd's configuration localServerCertSANs field",
+			expectErr: false,
 			before:    before,
 			kcp:       localServerCertSANs,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's local etcd's configuration localExtraArgs field",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's local etcd's configuration localExtraArgs field",
+			expectErr: false,
 			before:    before,
 			kcp:       localExtraArgs,
 		},
 		{
-			name:      "should fail when making a change to the cluster config's external etcd's configuration",
-			expectErr: true,
+			name:      "should not fail when making a change to the cluster config's external etcd's configuration",
+			expectErr: false,
 			before:    before,
 			kcp:       externalEtcd,
 		},
 		{
-			name:      "should fail when attempting to unset the etcd local object",
-			expectErr: true,
+			name:      "should not fail when attempting to unset the etcd local object",
+			expectErr: false,
 			before:    etcdLocalImageTag,
 			kcp:       unsetEtcd,
 		},
 		{
-			name:      "should fail when modifying a field that is not the local etcd image metadata",
-			expectErr: true,
+			name:      "should not fail when modifying a field that is not the local etcd image metadata",
+			expectErr: false,
 			before:    localDataDir,
 			kcp:       modifyLocalDataDir,
 		},