Fix html repr on non-str keys (pydata#3870)

* fix html repr on non-str keys

* whatsnew

* Update doc/whats-new.rst

Co-Authored-By: keewis <[email protected]>

Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: keewis <[email protected]>

Author: 3 people

doc/whats-new.rst

@@ -94,6 +94,8 @@ Bug fixes
 
 - Fix :py:meth:`xarray.core.dataset.Dataset.to_zarr` when using `append_dim` and `group`
   simultaneously. (:issue:`3170`). By `Matthias Meyer <https://github.com/niowniow>`_.
+- Fix html repr on :py:class:`Dataset` with non-string keys (:pull:`3807`).
+  By `Maximilian Roos <https://github.com/max-sixty>`_.
 
 Documentation
 ~~~~~~~~~~~~~

xarray/core/formatting_html.py

@@ -95,7 +95,7 @@ def summarize_variable(name, var, is_index=False, dtype=None, preview=None):
 
     cssclass_idx = " class='xr-has-index'" if is_index else ""
     dims_str = f"({', '.join(escape(dim) for dim in var.dims)})"
-    name = escape(name)
+    name = escape(str(name))
     dtype = dtype or escape(str(var.dtype))
 
     # "unique" ids required to expand/collapse subsections

xarray/tests/test_formatting_html.py

@@ -51,6 +51,11 @@ def test_short_data_repr_html(dataarray):
     assert data_repr.startswith("array")
 
 
+def test_short_data_repr_html_non_str_keys(dataset):
+    ds = dataset.assign({2: lambda x: x["tmin"]})
+    fh.dataset_repr(ds)
+
+
 def test_short_data_repr_html_dask(dask_dataarray):
     import dask