Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove heading from search box in sphinx13 style #10791

Closed
timhoffm opened this issue Aug 28, 2022 · 2 comments · Fixed by #11045
Closed

Remove heading from search box in sphinx13 style #10791

timhoffm opened this issue Aug 28, 2022 · 2 comments · Fixed by #11045
Labels
type:enhancement enhance or introduce a new feature

Comments

@timhoffm
Copy link
Contributor

timhoffm commented Aug 28, 2022

The heading takes extra space and adds a bit of clutter. Since the only element in the section is the input field we can as well only show the input field and use the placeholder to spell out "Search".

Current (left) / suggestion (right):

grafik grafik

Since the search box is a component (searchbox.html), which may need to stay as is for compatibility, I suggest to introduce a new reduced component (e.g. searchfield.html) and use that for sphinx13.

Let me know what you think. I can come up with a PR if there is interest for it.

@timhoffm timhoffm added the type:enhancement enhance or introduce a new feature label Aug 28, 2022
@AA-Turner
Copy link
Member

Seems useful, thank you.

A

@timhoffm
Copy link
Contributor Author

👍 I will put up a PR in a couple of days.

@AA-Turner AA-Turner added this to the some future version milestone Sep 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants