Skip to content

Commit 87fea2b

Browse files
committed
chore!(outbound-pg): Drop int8 support
There are a few reasons to do this: - the only pg type that fits into 1 byte is special "char" type which isn't intended for general-purpose use[1]; - naming is confusing: in the SDK it makes sense to decode it into i8 but in fact it has to be decoded into char; - in fact, it was never supported - there is no code to decode/encode it and such columns handled as DbValue::Unsupported/DbDataType::Other; [1]: https://www.postgresql.org/docs/current/datatype-character.html
1 parent 8be912c commit 87fea2b

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

crates/outbound-pg/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ fn to_sql_parameter<'a>(value: &'a ParameterValue) -> anyhow::Result<&'a (dyn To
101101
ParameterValue::Boolean(v) => Ok(v),
102102
ParameterValue::Int32(v) => Ok(v),
103103
ParameterValue::Int64(v) => Ok(v),
104-
ParameterValue::Int8(v) => Ok(v),
105104
ParameterValue::Int16(v) => Ok(v),
106105
ParameterValue::Floating32(v) => Ok(v),
107106
ParameterValue::Floating64(v) => Ok(v),

wit/ephemeral/rdbms-types.wit

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
enum db-data-type {
22
boolean,
3-
int8,
43
int16,
54
int32,
65
int64,
@@ -17,7 +16,6 @@ enum db-data-type {
1716

1817
variant db-value {
1918
boolean(bool),
20-
int8(s8),
2119
int16(s16),
2220
int32(s32),
2321
int64(s64),
@@ -35,7 +33,6 @@ variant db-value {
3533

3634
variant parameter-value {
3735
boolean(bool),
38-
int8(s8),
3936
int16(s16),
4037
int32(s32),
4138
int64(s64),

0 commit comments

Comments
 (0)