Improve error handling on failed post to http.

Author: Corneil du Plessis

spring-cloud-dataflow-rest-client/src/main/java/org/springframework/cloud/dataflow/rest/client/RuntimeTemplate.java

@@ -28,6 +28,7 @@
 import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpMethod;
+import org.springframework.http.ResponseEntity;
 import org.springframework.util.Assert;
 import org.springframework.web.client.RestTemplate;
 
@@ -131,6 +132,9 @@ public void postToUrl(String appId, String instanceId, byte[] data, HttpHeaders
 		Assert.notNull(appUrlPostUriTemplate, "post endpoint not found");
 		String uri = appUrlPostUriTemplate.expand(appId, instanceId).getHref();
 		HttpEntity<byte[]> entity = new HttpEntity<>(data, headers);
-		this.restTemplate.exchange(uri, HttpMethod.POST, entity, String.class);
+		ResponseEntity<String> response = this.restTemplate.exchange(uri, HttpMethod.POST, entity, String.class);
+		if(!response.getStatusCode().is2xxSuccessful()) {
+			throw new RuntimeException("POST:exception:" + response.getStatusCode() + ":" + response.getBody());
+		}
 	}
 }

spring-cloud-dataflow-server/src/test/java/org/springframework/cloud/dataflow/integration/test/util/RuntimeApplicationHelper.java

@@ -30,6 +30,7 @@
 
 import org.springframework.cloud.dataflow.core.ApplicationType;
 import org.springframework.cloud.dataflow.core.StreamRuntimePropertyKeys;
+import org.springframework.cloud.dataflow.rest.client.DataFlowClientException;
 import org.springframework.cloud.dataflow.rest.client.DataFlowTemplate;
 import org.springframework.cloud.dataflow.rest.resource.AppInstanceStatusResource;
 import org.springframework.cloud.dataflow.rest.resource.AppStatusResource;
@@ -40,6 +41,7 @@
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpMethod;
 import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
 import org.springframework.util.Assert;
 import org.springframework.util.CollectionUtils;
 import org.springframework.util.StringUtils;
@@ -278,7 +280,10 @@ public void httpPostJson(String streamName, String appName, Object obj) throws J
 
 
     public void httpPost(String url, String message) {
-        dataFlowTemplate.getRestTemplate().postForObject(url, message, String.class);
+        ResponseEntity<String> response = dataFlowTemplate.getRestTemplate().postForEntity(url, message, String.class);
+        if(!response.getStatusCode().is2xxSuccessful()) {
+            throw new RuntimeException("Exception posting:" + response.getStatusCode()+":" + response.getBody());
+        }
     }
 
     public void httpPost(String streamName, String appName, byte[] message, HttpHeaders headers) {
@@ -319,11 +324,22 @@ public void httpPost(String streamName, String appName, byte[] message, HttpHead
 				String url = instance.getAttributes().get("url");
 				if(StringUtils.hasText(url)) {
 					HttpEntity<byte[]> httpEntity = new HttpEntity<>(message, headers);
-					this.dataFlowTemplate.getRestTemplate().exchange(url, HttpMethod.POST, httpEntity, String.class);
+					ResponseEntity<String> response = this.dataFlowTemplate.getRestTemplate().exchange(url, HttpMethod.POST, httpEntity, String.class);
+                    if(!response.getStatusCode().is2xxSuccessful()) {
+                        throw new RuntimeException("POST:exception:" + response.getStatusCode() + ":" + response.getBody());
+                    }
 				} else {
 					throw new RuntimeException("Cannot find url for " + streamName + ":" + appName);
 				}
-			}
+			} else {
+                if(x instanceof DataFlowClientException) {
+                    throw (DataFlowClientException) x;
+                } else if(x instanceof RuntimeException) {
+                    throw (RuntimeException) x;
+                } else {
+                    throw new RuntimeException(x.getMessage(), x);
+                }
+            }
 		}
     }