Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Missing the auto-configuration of CoroutineSortingRepository #643

Closed
nfrankel opened this issue Mar 22, 2021 · 3 comments · Fixed by #759
Closed

Missing the auto-configuration of CoroutineSortingRepository #643

nfrankel opened this issue Mar 22, 2021 · 3 comments · Fixed by #759
Assignees
Labels
type: bug A general bug
Milestone

Comments

@nfrankel
Copy link

As mentioned in this post, the auto-configuration of proxies fail on the CoroutineSortingRepository.

Please check this project for a reproducer.

@sdeleuze sdeleuze added status: waiting-for-triage An issue we've not yet triaged or decided on type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 22, 2021
@sdeleuze sdeleuze added this to the 0.9.2 milestone Mar 22, 2021
@sdeleuze
Copy link
Contributor

As discussed with @christophstrobl, we should probably add a Coroutines R2DBC sample and refine the processor logic accordingly.

@sdeleuze sdeleuze modified the milestones: 0.9.2, 0.10.0 Apr 13, 2021
@sdeleuze
Copy link
Contributor

See also the other repro project from #735.

@sdeleuze
Copy link
Contributor

sdeleuze commented May 6, 2021

The root issue is that we don't use kotlin-reflect, so for methods using Coroutines, the return value detected in Object not the real return type because that's how Coroutines are compiled at bytecode level. Our fix is specific to this Spring Data Coroutines use case, but given how popular they are, I think it is worth to have it. I have created #769 to solve the root issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A general bug
3 participants