Polish RefreshScopeBeanDefinitionEnhancer.setRefreshable()

izeye · izeye · commit 05a19cbbc13e · 2018-04-30T16:12:40.000+09:00
diff --git a/spring-cloud-context/src/main/java/org/springframework/cloud/autoconfigure/RefreshAutoConfiguration.java b/spring-cloud-context/src/main/java/org/springframework/cloud/autoconfigure/RefreshAutoConfiguration.java
@@ -100,9 +100,10 @@ public Set<String> getRefreshable() {
 		}
 
 		public void setRefreshable(Set<String> refreshables) {
-			if (this.refreshables != refreshables) {
-				this.refreshables.clear();
+			if (this.refreshables == refreshables) {
+				return;
 			}
+			this.refreshables.clear();
 			this.refreshables.addAll(refreshables);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -100,9 +100,10 @@ public Set<String> getRefreshable() {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`public void setRefreshable(Set<String> refreshables) {`
`103`		`- if (this.refreshables != refreshables) {`
`104`		`- this.refreshables.clear();`
	`103`	`+ if (this.refreshables == refreshables) {`
	`104`	`+ return;`
`105`	`105`	`}`
	`106`	`+ this.refreshables.clear();`
`106`	`107`	`this.refreshables.addAll(refreshables);`
`107`	`108`	`}`
`108`	`109`