Skip to content

Replace RestTemplate with WebClient #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sabbyanandan opened this issue Jan 23, 2020 · 2 comments
Closed

Replace RestTemplate with WebClient #3758

sabbyanandan opened this issue Jan 23, 2020 · 2 comments
Assignees

Comments

@sabbyanandan
Copy link
Contributor

sabbyanandan commented Jan 23, 2020

As the framework will be deprecating the RestTemplate in the future, we would want to adapt to the WebClient pattern in SCDF RESTful clients, including the Java DSL.

All of the RESTful resources use RestTemplate today. Outside of the clients in the SCDF repo, we may have to review the integration possibilities done in the following client applications.

  • CTR
  • TaskLauncher Dataflow
  • TaskLauncher Schedules
  • Security Commons (utility used by both scdf and skipper)
@cppwfs
Copy link
Contributor

cppwfs commented Jan 23, 2020

We will need to update the DataflowTemplate to use WebClient instead of RestTemplate. This is a precursor that has to be done before updating CTR, SchedulerLauncher

@sabbyanandan sabbyanandan added wontfix and removed type/epic Collection of issues labels Feb 11, 2020
@sabbyanandan
Copy link
Contributor Author

Based on the discussion with the Spring Framework team, we conclude that RestTemplate is in maintenance-only mode, and it is not slated for deprecation anytime soon.

The corresponding RestTemplate javadocs has been updated with the clarification — see spring-projects/spring-framework#24503.

There's nothing more to do from SCDF's use of RestTemplate at this time of writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants