Skip to content

Implement Client Registration Model / Repository #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgrandja opened this issue Apr 20, 2020 · 2 comments · Fixed by #70
Closed

Implement Client Registration Model / Repository #40

jgrandja opened this issue Apr 20, 2020 · 2 comments · Fixed by #70
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@jgrandja
Copy link
Collaborator

jgrandja commented Apr 20, 2020

An authorization server must provide a mechanism(s) for registering Clients.

The initial implementation should provide an in-memory implementation of RegisteredClientRepository, similar to InMemoryClientRegistrationRepository in the spring-security-oauth2-client module.

Implementation Requirements

  • InMemoryRegisteredClientRepository should store in a Map
  • RegisteredClient should provide a Builder, similar to ClientRegistration
  • RegisteredClient should be immutable
  • javadoc class and public methods
  • Unit tests

Specification References

2. Client Registration

@jgrandja jgrandja changed the title Client Registration Service Epic: Client Registration Service Apr 20, 2020
@jgrandja jgrandja added the status: on-hold We can't start working on this issue yet label Apr 23, 2020
@jgrandja jgrandja changed the title Epic: Client Registration Service Implement Client Registration Model / Service Apr 24, 2020
@jgrandja jgrandja changed the title Implement Client Registration Model / Service Implement Client Registration Model / Repository Apr 24, 2020
@jgrandja jgrandja added this to the 0.0.1 milestone Apr 24, 2020
@jgrandja jgrandja added status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement and removed status: on-hold We can't start working on this issue yet labels Apr 24, 2020
@anoopgarlapati
Copy link
Contributor

anoopgarlapati commented Apr 24, 2020

@jgrandja I would like to start work on this issue.
I want to understand if these classes should initially be in samples package or should I create a specific package for client registration similar to spring-security-oauth2-client module.
Edit: I just rebased my fork and I see that specific modules are created.

@jgrandja
Copy link
Collaborator Author

Thank you @anoopgarlapati. The issue is yours. See #65

@jgrandja jgrandja removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Apr 24, 2020
anoopgarlapati added a commit to anoopgarlapati/spring-authorization-server that referenced this issue Apr 25, 2020
anoopgarlapati added a commit to anoopgarlapati/spring-authorization-server that referenced this issue Apr 25, 2020
anoopgarlapati added a commit to anoopgarlapati/spring-authorization-server that referenced this issue Apr 26, 2020
anoopgarlapati added a commit to anoopgarlapati/spring-authorization-server that referenced this issue Apr 26, 2020
anoopgarlapati added a commit to anoopgarlapati/spring-authorization-server that referenced this issue Apr 28, 2020
anoopgarlapati added a commit to anoopgarlapati/spring-authorization-server that referenced this issue Apr 28, 2020
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
3 participants