Spring Boot sample #23
Conversation
|
This pull request is meant for #1 -- not sure how to link it to the issue. |
There was a problem hiding this comment.
Thanks, @tomvandenberge! In addition to the inlined feedback, I think it would be good to have a Boot main class in the sample package as well as a test class that confirms that the context loads.
There was a problem hiding this comment.
Looking good, @tomvandenberge! I've left a bit more feedback inline.
Also, to answer your question from earlier, if you have a commit that looks something like this:
Add Empty Boot Sample
Fixes gh-1
Then GitHub will link the PR and issue together. If you want, you could try squashing your commits for this PR all into one and have that message be the commit message.
Fixes #1
…horization-server � Conflicts: � settings.gradle � src/main/java/sample/Application.java � src/test/java/sample/ApplicationTest.java
|
Thanks for the feedback @jzheaux. I've tried to squash the changes, but I can't find how to do that in Intellij. The Squash Into option in the Git Log window remains disabled. I tried some things, and hope that I haven't messed it up too badly ;-) |
|
Thanks for the contribution, @tomvandenberge! I'm sorry that you had some issues with rebase, git can be a challenge sometimes. No worries, though, I was able to clean it up. I've merged everything to master via 82be38c. |
jzheaux
added
type: enhancement
This adds gradle configuration to create an empty Spring Boot project. Is this what you had in mind?