Add in-memory implementation for OAuth2AuthorizationService #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisztian-toth
commented
Apr 26, 2020
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
krisztian-toth
force-pushed
the
implement-in-memory-authorization-service
branch
from
fea0565 to
34c895d
Compare
r331
reviewed
Apr 27, 2020
jgrandja
requested changes
Apr 28, 2020
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Show resolved
Hide resolved
...ringframework/security/oauth2/server/authorization/AuthorizationCodeOAuth2Authorization.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/oauth2/server/authorization/TokenContainer.java
Outdated
Show resolved
Hide resolved
...org/springframework/security/oauth2/server/authorization/AccessTokenOAuth2Authorization.java
Outdated
Show resolved
Hide resolved
|
@jgrandja I updated the PR, let me know if it's headed in the right direction. Thanks! |
jgrandja
reviewed
May 1, 2020
...springframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationService.java
Outdated
Show resolved
Hide resolved
jgrandja
reviewed
May 1, 2020
...springframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationService.java
Outdated
Show resolved
Hide resolved
jgrandja
reviewed
May 1, 2020
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
jgrandja
reviewed
May 1, 2020
...ngframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationServiceTest.java
Outdated
Show resolved
Hide resolved
|
@jgrandja I updated the PR, let me know of any shortcomings. |
jgrandja
requested changes
May 6, 2020
...springframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationService.java
Outdated
Show resolved
Hide resolved
...springframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationService.java
Outdated
Show resolved
Hide resolved
...springframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationService.java
Outdated
Show resolved
Hide resolved
| * Creates an {@link InMemoryOAuth2AuthorizationService}. | ||
| */ | ||
| public InMemoryOAuth2AuthorizationService() { | ||
| this(new CopyOnWriteArrayList<>()); |
There was a problem hiding this comment.
Pass Collections.emptyList() instead
There was a problem hiding this comment.
Applied, though I think this defeats the purpose of this class, you won't be able to save authorizations into this in-memory store. Is that fine?
...springframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/server/authorization/OAuth2Authorization.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/authorization/InMemoryOAuth2AuthorizationServiceTest.java
Outdated
Show resolved
Hide resolved
krisztian-toth
force-pushed
the
implement-in-memory-authorization-service
branch
3 times, most recently
from
437ad78 to
20529dd
Compare
|
@jgrandja see my reply, PR is also updated |
krisztian-toth
force-pushed
the
implement-in-memory-authorization-service
branch
2 times, most recently
from
aef346f to
a243904
Compare
krisztian-toth
force-pushed
the
implement-in-memory-authorization-service
branch
from
a243904 to
7a6a316
Compare
|
Thanks for all the updates @watsta ! FYI, I added a polish commit to get this merged. This is now in master. |
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-43
Haven't provided unit tests yet,I am unsure about a few things, see comments.